[coreboot-gerrit] Change in coreboot[master]: intel/basecode/fw_upadte: Add ELOG events to ucode update

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Tue Oct 30 14:37:03 CET 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29357 )

Change subject: intel/basecode/fw_upadte: Add ELOG events to ucode update
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/29357/1/src/soc/intel/common/basecode/fw_update/elog.c
File src/soc/intel/common/basecode/fw_update/elog.c:

https://review.coreboot.org/#/c/29357/1/src/soc/intel/common/basecode/fw_update/elog.c@30
PS1, Line 30: 	return (elog_add_event_raw(event_type, &event, sizeof(event)));
return is not a function, parentheses are not required



-- 
To view, visit https://review.coreboot.org/29357
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idda32a1073b3dc8e3f57e079b69fc415a2837899
Gerrit-Change-Number: 29357
Gerrit-PatchSet: 1
Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 30 Oct 2018 13:37:03 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181030/a2e3459f/attachment.html>


More information about the coreboot-gerrit mailing list