<p><a href="https://review.coreboot.org/29357">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29357/1/src/soc/intel/common/basecode/fw_update/elog.c">File src/soc/intel/common/basecode/fw_update/elog.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29357/1/src/soc/intel/common/basecode/fw_update/elog.c@30">Patch Set #1, Line 30:</a> <code style="font-family:monospace,monospace">        return (elog_add_event_raw(event_type, &event, sizeof(event)));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">return is not a function, parentheses are not required</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/29357">change 29357</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29357"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Idda32a1073b3dc8e3f57e079b69fc415a2837899 </div>
<div style="display:none"> Gerrit-Change-Number: 29357 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi@intel.com> </div>
<div style="display:none"> Gerrit-CC: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 30 Oct 2018 13:37:03 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>