[coreboot-gerrit] Change in coreboot[master]: mb/google/fizz: Enable use of override devicetree

[Furquan Shaikh (Code Review)]

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/29242


Change subject: mb/google/fizz: Enable use of override devicetree
......................................................................

mb/google/fizz: Enable use of override devicetree

This change enables override device tree for Fizz to allow variants to
provide their own overrides and also moves I2C5 realtek node to
fizz/overridetree.cb since it doesn't apply to some variants being
added for Fizz.

Change-Id: Ia1a069fc539b51a22882ef94b55baf5bf7cd302f
Signed-off-by: Furquan Shaikh <furquan at google.com>
---
M src/mainboard/google/fizz/Kconfig
M src/mainboard/google/fizz/variants/baseboard/devicetree.cb
A src/mainboard/google/fizz/variants/fizz/overridetree.cb
3 files changed, 21 insertions(+), 9 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/29242/1

diff --git a/src/mainboard/google/fizz/Kconfig b/src/mainboard/google/fizz/Kconfig
index 6ab94c9..c82f809 100644
--- a/src/mainboard/google/fizz/Kconfig
+++ b/src/mainboard/google/fizz/Kconfig
@@ -29,6 +29,10 @@
 	string
 	default "variants/baseboard/devicetree.cb"
 
+config OVERRIDE_DEVICETREE
+	string
+	default "variants/$(CONFIG_VARIANT_DIR)/overridetree.cb"
+
 config VBOOT
 	select EC_GOOGLE_CHROMEEC_SWITCHES
 	select VBOOT_EC_EFS
diff --git a/src/mainboard/google/fizz/variants/baseboard/devicetree.cb b/src/mainboard/google/fizz/variants/baseboard/devicetree.cb
index 281d65c..ff0db37 100644
--- a/src/mainboard/google/fizz/variants/baseboard/devicetree.cb
+++ b/src/mainboard/google/fizz/variants/baseboard/devicetree.cb
@@ -418,15 +418,7 @@
 		device pci 16.4 off end # Management Engine Interface 3
 		device pci 17.0 on end # SATA
 		device pci 19.0 on  end # UART #2
-		device pci 19.1 on
-			chip drivers/i2c/generic
-				register "hid" = ""10EC5663""
-				register "name" = ""RT53""
-				register "desc" = ""Realtek RT5663""
-				register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_D9)"
-				device i2c 13 on end
-			end
-		end # I2C #5
+		device pci 19.1 on  end # I2C #5
 		device pci 19.2 off  end # I2C #4
 		device pci 1c.0 on end # PCI Express Port 1
 		device pci 1c.1 off end # PCI Express Port 2
diff --git a/src/mainboard/google/fizz/variants/fizz/overridetree.cb b/src/mainboard/google/fizz/variants/fizz/overridetree.cb
new file mode 100644
index 0000000..0d3c4fc
--- /dev/null
+++ b/src/mainboard/google/fizz/variants/fizz/overridetree.cb
@@ -0,0 +1,16 @@
+chip soc/intel/skylake
+
+	device domain 0 on
+		device pci 19.1 on
+			chip drivers/i2c/generic
+				register "hid" = ""10EC5663""
+				register "name" = ""RT53""
+				register "desc" = ""Realtek RT5663""
+				register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_D9)"
+				device i2c 13 on end
+			end
+		end # I2C #5
+
+	end
+
+end

-- 
To view, visit https://review.coreboot.org/29242
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia1a069fc539b51a22882ef94b55baf5bf7cd302f
Gerrit-Change-Number: 29242
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181023/6ed26856/attachment-0001.html>