[coreboot-gerrit] Change in coreboot[master]: mb/google/octopus: Use DIMM_INFO_PART_NUMBER_SIZE for part_num_store
Furquan Shaikh (Code Review)
gerrit at coreboot.org
Tue Oct 23 16:35:01 CEST 2018
Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/29241
Change subject: mb/google/octopus: Use DIMM_INFO_PART_NUMBER_SIZE for part_num_store
......................................................................
mb/google/octopus: Use DIMM_INFO_PART_NUMBER_SIZE for part_num_store
This change uses DIMM_INFO_PART_NUMBER_SIZE to decide the size of
part_num_store that holds the number of the DRAM part. It ensures that
host advertises the supported size to read part number from the EC.
BUG=b:115697578
Change-Id: I8439a301fc037b0acdc8b1226ad04d2f363838ef
Signed-off-by: Furquan Shaikh <furquan at google.com>
---
M src/mainboard/google/octopus/romstage.c
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/29241/1
diff --git a/src/mainboard/google/octopus/romstage.c b/src/mainboard/google/octopus/romstage.c
index 9e5734b..43349a0 100644
--- a/src/mainboard/google/octopus/romstage.c
+++ b/src/mainboard/google/octopus/romstage.c
@@ -17,6 +17,7 @@
#include <boardid.h>
#include <console/console.h>
#include <ec/google/chromeec/ec.h>
+#include <memory_info.h>
#include <soc/meminit.h>
#include <soc/romstage.h>
@@ -33,7 +34,7 @@
void mainboard_save_dimm_info(void)
{
- char part_num_store[32];
+ char part_num_store[DIMM_INFO_PART_NUMBER_SIZE];
const char *part_num = NULL;
if (!IS_ENABLED(CONFIG_DRAM_PART_NUM_IN_CBI)) {
--
To view, visit https://review.coreboot.org/29241
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8439a301fc037b0acdc8b1226ad04d2f363838ef
Gerrit-Change-Number: 29241
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181023/105f891a/attachment.html>
More information about the coreboot-gerrit
mailing list