<p>Furquan Shaikh has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/29241">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/octopus: Use DIMM_INFO_PART_NUMBER_SIZE for part_num_store<br><br>This change uses DIMM_INFO_PART_NUMBER_SIZE to decide the size of<br>part_num_store that holds the number of the DRAM part. It ensures that<br>host advertises the supported size to read part number from the EC.<br><br>BUG=b:115697578<br><br>Change-Id: I8439a301fc037b0acdc8b1226ad04d2f363838ef<br>Signed-off-by: Furquan Shaikh <furquan@google.com><br>---<br>M src/mainboard/google/octopus/romstage.c<br>1 file changed, 2 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/29241/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/octopus/romstage.c b/src/mainboard/google/octopus/romstage.c</span><br><span>index 9e5734b..43349a0 100644</span><br><span>--- a/src/mainboard/google/octopus/romstage.c</span><br><span>+++ b/src/mainboard/google/octopus/romstage.c</span><br><span>@@ -17,6 +17,7 @@</span><br><span> #include <boardid.h></span><br><span> #include <console/console.h></span><br><span> #include <ec/google/chromeec/ec.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <memory_info.h></span><br><span> #include <soc/meminit.h></span><br><span> #include <soc/romstage.h></span><br><span> </span><br><span>@@ -33,7 +34,7 @@</span><br><span> </span><br><span> void mainboard_save_dimm_info(void)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-    char part_num_store[32];</span><br><span style="color: hsl(120, 100%, 40%);">+      char part_num_store[DIMM_INFO_PART_NUMBER_SIZE];</span><br><span>     const char *part_num = NULL;</span><br><span> </span><br><span>     if (!IS_ENABLED(CONFIG_DRAM_PART_NUM_IN_CBI)) {</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/29241">change 29241</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29241"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I8439a301fc037b0acdc8b1226ad04d2f363838ef </div>
<div style="display:none"> Gerrit-Change-Number: 29241 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Furquan Shaikh <furquan@google.com> </div>