[coreboot-gerrit] Change in coreboot[master]: sdm845: Port I2C driver

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29104 )

Change subject: sdm845: Port I2C driver
......................................................................


Patch Set 3:

(4 comments)

https://review.coreboot.org/#/c/29104/3/src/soc/qualcomm/sdm845/i2c.c
File src/soc/qualcomm/sdm845/i2c.c:

https://review.coreboot.org/#/c/29104/3/src/soc/qualcomm/sdm845/i2c.c@279
PS3, Line 279: void i2c_init(unsigned qup_i2c_instance)
Prefer 'unsigned int' to bare use of 'unsigned'


https://review.coreboot.org/#/c/29104/3/src/soc/qualcomm/sdm845/i2c.c@440
PS3, Line 440: int platform_i2c_transfer(unsigned bus, struct i2c_msg *segments,
Prefer 'unsigned int' to bare use of 'unsigned'


https://review.coreboot.org/#/c/29104/3/src/soc/qualcomm/sdm845/include/soc/i2c.h
File src/soc/qualcomm/sdm845/include/soc/i2c.h:

https://review.coreboot.org/#/c/29104/3/src/soc/qualcomm/sdm845/include/soc/i2c.h@31
PS3, Line 31: 	unsigned initialized;
Prefer 'unsigned int' to bare use of 'unsigned'


https://review.coreboot.org/#/c/29104/3/src/soc/qualcomm/sdm845/include/soc/i2c.h@38
PS3, Line 38: void i2c_init(unsigned qup_i2c_instance);
Prefer 'unsigned int' to bare use of 'unsigned'



-- 
To view, visit https://review.coreboot.org/29104
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb76564d8a11427423dd14d8ba7c8c7d500ef346
Gerrit-Change-Number: 29104
Gerrit-PatchSet: 3
Gerrit-Owner: T.Michael Turney <tturne at codeaurora.org>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: T Michael Turney <mturney at codeaurora.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 22 Oct 2018 22:19:34 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181022/c11a6cfa/attachment.html>