<p><a href="https://review.coreboot.org/29104">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29104/3/src/soc/qualcomm/sdm845/i2c.c">File src/soc/qualcomm/sdm845/i2c.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29104/3/src/soc/qualcomm/sdm845/i2c.c@279">Patch Set #3, Line 279:</a> <code style="font-family:monospace,monospace">void i2c_init(unsigned qup_i2c_instance)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Prefer 'unsigned int' to bare use of 'unsigned'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29104/3/src/soc/qualcomm/sdm845/i2c.c@440">Patch Set #3, Line 440:</a> <code style="font-family:monospace,monospace">int platform_i2c_transfer(unsigned bus, struct i2c_msg *segments,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Prefer 'unsigned int' to bare use of 'unsigned'</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29104/3/src/soc/qualcomm/sdm845/include/soc/i2c.h">File src/soc/qualcomm/sdm845/include/soc/i2c.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29104/3/src/soc/qualcomm/sdm845/include/soc/i2c.h@31">Patch Set #3, Line 31:</a> <code style="font-family:monospace,monospace">    unsigned initialized;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Prefer 'unsigned int' to bare use of 'unsigned'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29104/3/src/soc/qualcomm/sdm845/include/soc/i2c.h@38">Patch Set #3, Line 38:</a> <code style="font-family:monospace,monospace">void i2c_init(unsigned qup_i2c_instance);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Prefer 'unsigned int' to bare use of 'unsigned'</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/29104">change 29104</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29104"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ifb76564d8a11427423dd14d8ba7c8c7d500ef346 </div>
<div style="display:none"> Gerrit-Change-Number: 29104 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: T.Michael Turney <tturne@codeaurora.org> </div>
<div style="display:none"> Gerrit-Reviewer: Julius Werner <jwerner@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: T Michael Turney <mturney@codeaurora.org> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 22 Oct 2018 22:19:34 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>