[coreboot-gerrit] Change in coreboot[master]: mb/lenovo/*/romstage: Use macros instead of magic numbers

[Peter Lemenkov (Code Review)]

Hello build bot (Jenkins), 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/29208

to look at the new patch set (#2).

Change subject: mb/lenovo/*/romstage: Use macros instead of magic numbers
......................................................................

mb/lenovo/*/romstage: Use macros instead of magic numbers

Apparently coreboot still uses magic numbers instead of macros in some
Lenovo mainboards. Let's use macros instead.

Please, take a look at the following diff:

        /* Set up I/O Trap #0 for 0xfe00 (SMIC) */
        RCBA32(0x1e84) = 0x00020001;
-       RCBA32(0x1e80) = 0x0000fe01;
+       RCBA32(IOTR0) = 0x0000fe01;

IOTR[0123] is a 64-bit width variable. Unfortunately, we don't have
RCBA64 macro yet so we have to use two RCBA32's here.

lemenkov ~/work/coreboot (git::master): grep -R IOTR0 src/southbridge/
src/southbridge/intel/i82801gx/i82801gx.h:#define IOTR0		0x1e80	/* 64bit */
src/southbridge/intel/ibexpeak/pch.h:#define IOTR0		0x1e80	/* 64bit */
src/southbridge/intel/bd82x6x/pch.h:#define IOTR0		0x1e80	/* 64bit */
src/southbridge/intel/fsp_bd82x6x/pch.h:#define IOTR0		0x1e80	/* 64bit */
src/southbridge/intel/lynxpoint/pch.h:#define IOTR0		0x1e80	/* 64bit */
lemenkov ~/work/coreboot (git::master):

Change-Id: Icf185c77ede5a258fe37be9e772be6804d014b57
Signed-off-by: Peter Lemenkov <lemenkov at gmail.com>
---
M src/mainboard/lenovo/t60/romstage.c
M src/mainboard/lenovo/x60/romstage.c
2 files changed, 8 insertions(+), 8 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/29208/2
-- 
To view, visit https://review.coreboot.org/29208
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icf185c77ede5a258fe37be9e772be6804d014b57
Gerrit-Change-Number: 29208
Gerrit-PatchSet: 2
Gerrit-Owner: Peter Lemenkov <lemenkov at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181022/45f0ee6d/attachment.html>