[coreboot-gerrit] Change in coreboot[master]: mb/lenovo/*/romstage: Use macros instead of magic numbers

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/28976 )

Change subject: mb/lenovo/*/romstage: Use macros instead of magic numbers
......................................................................


Patch Set 3:

(4 comments)

https://review.coreboot.org/#/c/28976/3/src/mainboard/lenovo/l520/romstage.c
File src/mainboard/lenovo/l520/romstage.c:

https://review.coreboot.org/#/c/28976/3/src/mainboard/lenovo/l520/romstage.c@32
PS3, Line 32: FDD_LPC_EN
There's no floppy


https://review.coreboot.org/#/c/28976/3/src/mainboard/lenovo/l520/romstage.c@37
PS3, Line 37: 0x000000)
That's the power on default, no need to write it.


https://review.coreboot.org/#/c/28976/3/src/mainboard/lenovo/l520/romstage.c@42
PS3, Line 42: RCBA32
Power on default ?


https://review.coreboot.org/#/c/28976/3/src/mainboard/lenovo/s230u/romstage.c
File src/mainboard/lenovo/s230u/romstage.c:

https://review.coreboot.org/#/c/28976/3/src/mainboard/lenovo/s230u/romstage.c@46
PS3, Line 46: 0xd8
What's 0xd8 ? Can you add a MACRO for that ?



-- 
To view, visit https://review.coreboot.org/28976
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6468e3357f8eed434f8527a852e134380f486d9a
Gerrit-Change-Number: 28976
Gerrit-PatchSet: 3
Gerrit-Owner: Peter Lemenkov <lemenkov at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Patrick Rudolph <siro at das-labor.org>
Gerrit-Comment-Date: Fri, 12 Oct 2018 12:07:20 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181012/8b636058/attachment.html>