[coreboot-gerrit] Change in coreboot[master]: minnowmax: allow both 1333 and 1066 MHz memory SKUs

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27989 )

Change subject: minnowmax: allow both 1333 and 1066 MHz memory SKUs
......................................................................


Patch Set 4:

(8 comments)

https://review.coreboot.org/#/c/27989/4/src/mainboard/intel/minnowmax/romstage.c
File src/mainboard/intel/minnowmax/romstage.c:

https://review.coreboot.org/#/c/27989/4/src/mainboard/intel/minnowmax/romstage.c@61
PS4, Line 61: 	.DRAMType = 1,       /* DRAM Type: 0=DDR3, 1=DDR3L, 2=DDR3U, 4=LPDDR2, 5=LPDDR3, 6=DDR4*/
line over 80 characters


https://review.coreboot.org/#/c/27989/4/src/mainboard/intel/minnowmax/romstage.c@65
PS4, Line 65: 	.DIMMDensity = 1,    /* DRAM device data density: 0=1Gb, 1=2Gb, 2=4Gb, 3=8Gb */
line over 80 characters


https://review.coreboot.org/#/c/27989/4/src/mainboard/intel/minnowmax/romstage.c@66
PS4, Line 66: 	.DIMMBusWidth = 3,   /* DIMM Bus Width: 0=8bit, 1=16bit, 2=32bit, 3=64bit */
line over 80 characters


https://review.coreboot.org/#/c/27989/4/src/mainboard/intel/minnowmax/romstage.c@69
PS4, Line 69: 	.DIMMtRPtRCD = 11,    /* tRP and tRCD in DRAM clk - 5:12.5ns, 6:15ns, etc. */
line over 80 characters


https://review.coreboot.org/#/c/27989/4/src/mainboard/intel/minnowmax/romstage.c@80
PS4, Line 80: 	.DRAMType = 1,       /* DRAM Type: 0=DDR3, 1=DDR3L, 2=DDR3U, 4=LPDDR2, 5=LPDDR3, 6=DDR4*/
line over 80 characters


https://review.coreboot.org/#/c/27989/4/src/mainboard/intel/minnowmax/romstage.c@84
PS4, Line 84: 	.DIMMDensity = 1,    /* DRAM device data density: 0=1Gb, 1=2Gb, 2=4Gb, 3=8Gb */
line over 80 characters


https://review.coreboot.org/#/c/27989/4/src/mainboard/intel/minnowmax/romstage.c@85
PS4, Line 85: 	.DIMMBusWidth = 3,   /* DIMM Bus Width: 0=8bit, 1=16bit, 2=32bit, 3=64bit */
line over 80 characters


https://review.coreboot.org/#/c/27989/4/src/mainboard/intel/minnowmax/romstage.c@88
PS4, Line 88: 	.DIMMtRPtRCD = 9,    /* tRP and tRCD in DRAM clk - 5:12.5ns, 6:15ns, etc. */
line over 80 characters



-- 
To view, visit https://review.coreboot.org/27989
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e57dd419b443dfa742c8812cec87274af557728
Gerrit-Change-Number: 27989
Gerrit-PatchSet: 4
Gerrit-Owner: Michał Żygowski <michal.zygowski at 3mdeb.com>
Gerrit-Reviewer: Huang Jin <huang.jin at intel.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski at 3mdeb.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Piotr Król <piotr.krol at 3mdeb.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer at coreboot.org>
Gerrit-Reviewer: York Yang <york.yang at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 15 Oct 2018 08:21:42 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181015/b12b8ce3/attachment.html>