[coreboot-gerrit] Change in coreboot[master]: libpayload: arm64: Add GDB support

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29020 )

Change subject: libpayload: arm64: Add GDB support
......................................................................


Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/29020/1/payloads/libpayload/arch/arm64/gdb.c
File payloads/libpayload/arch/arm64/gdb.c:

https://review.coreboot.org/#/c/29020/1/payloads/libpayload/arch/arm64/gdb.c@49
PS1, Line 49: 		else switch (exception_state.ec) {
trailing statements should be on next line


https://review.coreboot.org/#/c/29020/1/payloads/libpayload/arch/arm64/gdb.c@91
PS1, Line 91: 	asm volatile ("mov %0, sp" : "=r"(sp) );
space prohibited before that close parenthesis ')'



-- 
To view, visit https://review.coreboot.org/29020
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fa4dbca6c39f822f489a5e81bd052f53fda98a5
Gerrit-Change-Number: 29020
Gerrit-PatchSet: 1
Gerrit-Owner: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 10 Oct 2018 23:22:07 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181010/af17df33/attachment.html>