[coreboot-gerrit] Change in coreboot[master]: libpayload: arm64: Conform to new coreboot lib_helpers.h and assume EL2

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Thu Oct 11 01:21:58 CEST 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29017 )

Change subject: libpayload: arm64: Conform to new coreboot lib_helpers.h and assume EL2
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/29017/1/payloads/libpayload/include/arm64/arch/lib_helpers.h
File payloads/libpayload/include/arm64/arch/lib_helpers.h:

https://review.coreboot.org/#/c/29017/1/payloads/libpayload/include/arm64/arch/lib_helpers.h@54
PS1, Line 54: #define MAKE_REGISTER_ACCESSORS_EL12(reg) \
Macros with complex values should be enclosed in parentheses



-- 
To view, visit https://review.coreboot.org/29017
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9dfa48411f3805747613f03611f8a134a51cc46
Gerrit-Change-Number: 29017
Gerrit-PatchSet: 1
Gerrit-Owner: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 10 Oct 2018 23:21:58 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181010/b3a0796b/attachment.html>


More information about the coreboot-gerrit mailing list