<p><a href="https://review.coreboot.org/29020">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29020/1/payloads/libpayload/arch/arm64/gdb.c">File payloads/libpayload/arch/arm64/gdb.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29020/1/payloads/libpayload/arch/arm64/gdb.c@49">Patch Set #1, Line 49:</a> <code style="font-family:monospace,monospace">             else switch (exception_state.ec) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">trailing statements should be on next line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29020/1/payloads/libpayload/arch/arm64/gdb.c@91">Patch Set #1, Line 91:</a> <code style="font-family:monospace,monospace">   asm volatile ("mov %0, sp" : "=r"(sp) );</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited before that close parenthesis ')'</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/29020">change 29020</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29020"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I2fa4dbca6c39f822f489a5e81bd052f53fda98a5 </div>
<div style="display:none"> Gerrit-Change-Number: 29020 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Julius Werner <jwerner@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org> </div>
<div style="display:none"> Gerrit-CC: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 10 Oct 2018 23:22:07 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>