[coreboot-gerrit] Change in coreboot[master]: dynamic UART initialization for cavium cn8100

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/28975 )

Change subject: dynamic UART initialization for cavium cn8100
......................................................................


Patch Set 1:

(4 comments)

Tested on hardware ?

https://review.coreboot.org/#/c/28975/1//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/28975/1//COMMIT_MSG@7
PS1, Line 7: dynamic UART initialization for cavium cn8100
Add prefix: soc/cavium:


https://review.coreboot.org/#/c/28975/1//COMMIT_MSG@8
PS1, Line 8: 
missing commit body


https://review.coreboot.org/#/c/28975/1/src/soc/cavium/cn81xx/soc.c
File src/soc/cavium/cn81xx/soc.c:

https://review.coreboot.org/#/c/28975/1/src/soc/cavium/cn81xx/soc.c@395
PS1, Line 395: 	struct device *child;
struct device *dev;


https://review.coreboot.org/#/c/28975/1/src/soc/cavium/cn81xx/soc.c@397
PS1, Line 397: 		child = dev_find_slot(1, PCI_DEVFN(8, i));
Add comment: using device enable state from devicetree.cb ?



-- 
To view, visit https://review.coreboot.org/28975
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I145c224148f0cc078bb1c76f588f603e73121a62
Gerrit-Change-Number: 28975
Gerrit-PatchSet: 1
Gerrit-Owner: Jens Drenhaus <jens.drenhaus at 9elements.com>
Gerrit-Reviewer: Jens Drenhaus <jens.drenhaus at 9elements.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph at 9elements.com>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Comment-Date: Tue, 09 Oct 2018 11:17:23 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181009/5a0534e9/attachment.html>