<p style="white-space: pre-wrap; word-wrap: break-word;">Tested on hardware ?</p><p><a href="https://review.coreboot.org/28975">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/28975/1//COMMIT_MSG">Commit Message:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28975/1//COMMIT_MSG@7">Patch Set #1, Line 7:</a> <code style="font-family:monospace,monospace">dynamic UART initialization for cavium cn8100</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Add prefix: soc/cavium:</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28975/1//COMMIT_MSG@8">Patch Set #1, Line 8:</a> <code style="font-family:monospace,monospace"></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">missing commit body</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/28975/1/src/soc/cavium/cn81xx/soc.c">File src/soc/cavium/cn81xx/soc.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28975/1/src/soc/cavium/cn81xx/soc.c@395">Patch Set #1, Line 395:</a> <code style="font-family:monospace,monospace">       struct device *child;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">struct device *dev;</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28975/1/src/soc/cavium/cn81xx/soc.c@397">Patch Set #1, Line 397:</a> <code style="font-family:monospace,monospace">              child = dev_find_slot(1, PCI_DEVFN(8, i));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Add comment: using device enable state from devicetree.cb ?</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/28975">change 28975</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28975"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I145c224148f0cc078bb1c76f588f603e73121a62 </div>
<div style="display:none"> Gerrit-Change-Number: 28975 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Jens Drenhaus <jens.drenhaus@9elements.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jens Drenhaus <jens.drenhaus@9elements.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph@9elements.com> </div>
<div style="display:none"> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 09 Oct 2018 11:17:23 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>