[coreboot-gerrit] Change in coreboot[master]: lenovo/x230: introduce FHD variant

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/28950 )

Change subject: lenovo/x230: introduce FHD variant
......................................................................


Patch Set 3:

> I am trying to compile after a `make distclean` and noticed if
> building with an existing .config it will error complaining that
> data.vbt cannot be found.

Reusing a *complete* .config for an older coreboot revision is
always somehow fragile and discouraged. The best option you
have currently is to use `make savedefconfig` (with a checkout
of the older revision). It will create a `defconfig` file with
only those settings that differ from the defaults. Then use
this `defconfig` as your .config after switching to the new
revision. Note, this `defconfig` is also stored inside the
CBFS of your coreboot image.


-- 
To view, visit https://review.coreboot.org/28950
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0355d39a61956792e69bccd5274cfc2749d72bf0
Gerrit-Change-Number: 28950
Gerrit-PatchSet: 3
Gerrit-Owner: Alexander Couzens <lynxis at fe80.eu>
Gerrit-Reviewer: Alexander Couzens <lynxis at fe80.eu>
Gerrit-Reviewer: Angel Pons <th3fanbus at gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Nico Huber <nico.h at gmx.de>
Gerrit-CC: Tom Hiller <thrilleratplay at gmail.com>
Gerrit-Comment-Date: Mon, 08 Oct 2018 07:39:54 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181008/3fa6d42b/attachment.html>