[coreboot-gerrit] Change in coreboot[master]: lenovo/x230: introduce FHD variant

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/28950 )

Change subject: lenovo/x230: introduce FHD variant
......................................................................


Patch Set 3:

> Patch Set 3:
> 
> I am trying to compile after a `make distclean` and noticed if building with an existing .config it will error complaining that data.vbt cannot be found.  This will be frustrating for both x230fhd and x230 users.  Is there any way to migrate config settings to be:
> 
> CONFIG_INTEL_GMA_VBT_FILE="src/mainboard/$(MAINBOARDDIR)/variants/$(VARIANT_DIR)/data.vbt"

That would require overriding the variant mechanism, AFAIK. And it's not like the VBT path is hidden or something, it can be easily changed by hand.


-- 
To view, visit https://review.coreboot.org/28950
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0355d39a61956792e69bccd5274cfc2749d72bf0
Gerrit-Change-Number: 28950
Gerrit-PatchSet: 3
Gerrit-Owner: Alexander Couzens <lynxis at fe80.eu>
Gerrit-Reviewer: Alexander Couzens <lynxis at fe80.eu>
Gerrit-Reviewer: Angel Pons <th3fanbus at gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Nico Huber <nico.h at gmx.de>
Gerrit-CC: Tom Hiller <thrilleratplay at gmail.com>
Gerrit-Comment-Date: Sun, 07 Oct 2018 14:15:00 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181007/0778e6b3/attachment.html>