[coreboot-gerrit] Change in coreboot[master]: lenovo/x230: introduce FHD variant

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/28950 )

Change subject: lenovo/x230: introduce FHD variant
......................................................................


Patch Set 3:

> Patch Set 3:
> 
> > Patch Set 3: Code-Review+1
> > 
> > I might be bikeshedding, but I think the folder name "x230fhd" is a bit hard to read. I'd use "x230-fhd" or "x230_fhd" instead, just like the macro names and topic on gerrit.
> 
> I would then rename it to oem and fhd as variant

"x230-stock" and "x230-fhd" seem good to me.


-- 
To view, visit https://review.coreboot.org/28950
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0355d39a61956792e69bccd5274cfc2749d72bf0
Gerrit-Change-Number: 28950
Gerrit-PatchSet: 3
Gerrit-Owner: Alexander Couzens <lynxis at fe80.eu>
Gerrit-Reviewer: Alexander Couzens <lynxis at fe80.eu>
Gerrit-Reviewer: Angel Pons <th3fanbus at gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Nico Huber <nico.h at gmx.de>
Gerrit-CC: Tom Hiller <thrilleratplay at gmail.com>
Gerrit-Comment-Date: Mon, 08 Oct 2018 14:01:48 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181008/08a19b49/attachment.html>