[coreboot-gerrit] Change in coreboot[master]: mb/google/kahlee/variants/liara: Update H1/TP/TS i2c timings

Chris Zhou (Code Review) gerrit at coreboot.org
Mon Oct 8 05:40:26 CEST 2018


Chris Zhou has uploaded this change for review. ( https://review.coreboot.org/28960


Change subject: mb/google/kahlee/variants/liara: Update H1/TP/TS i2c timings
......................................................................

mb/google/kahlee/variants/liara: Update H1/TP/TS i2c timings

After adjustment on Liara EVT
H1: 392.03 KHz
TP: 397.87 KHz
TS: 397.71 KHz

BUG=b:116309237
BRANCH=master
TEST=emerge-grunt coreboot chromeos-bootimage
     measure by scope

Change-Id: Ib5d7ce09ac58f33ee826d7541e1a0d14a03add9a
Signed-off-by: Chris Zhou <chris_zhou at compal.corp-partner.google.com>
---
M src/mainboard/google/kahlee/variants/liara/devicetree.cb
1 file changed, 6 insertions(+), 6 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/28960/1

diff --git a/src/mainboard/google/kahlee/variants/liara/devicetree.cb b/src/mainboard/google/kahlee/variants/liara/devicetree.cb
index a213492..0dfe204 100644
--- a/src/mainboard/google/kahlee/variants/liara/devicetree.cb
+++ b/src/mainboard/google/kahlee/variants/liara/devicetree.cb
@@ -32,22 +32,22 @@
 	register "i2c[1]" = "{
 		.early_init = 1,
 		.speed = I2C_SPEED_FAST,
-		.rise_time_ns = 45,
-		.fall_time_ns = 4,
+		.rise_time_ns = 3,
+		.fall_time_ns = 2,
 	}"
 
 	# Enable I2C2 for trackpad, pen at 400kHz
 	register "i2c[2]" = "{
 		.speed = I2C_SPEED_FAST,
-		.rise_time_ns = 48,
-		.fall_time_ns = 37,
+		.rise_time_ns = 3,
+		.fall_time_ns = 2,
 	}"
 
 	# Enable I2C3 for touchscreen at 400kHz
 	register "i2c[3]" = "{
 		.speed = I2C_SPEED_FAST,
-		.rise_time_ns = 82,
-		.fall_time_ns = 67,
+		.rise_time_ns = 16,
+		.fall_time_ns = 8,
 	}"
 
 	device cpu_cluster 0 on

-- 
To view, visit https://review.coreboot.org/28960
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib5d7ce09ac58f33ee826d7541e1a0d14a03add9a
Gerrit-Change-Number: 28960
Gerrit-PatchSet: 1
Gerrit-Owner: Chris Zhou <chris_zhou at compal.corp-partner.google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181008/c27dcfb1/attachment-0001.html>


More information about the coreboot-gerrit mailing list