[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/acpi: Fix ACPI Namespace lookup failure, AE_ALREADY_...

Subrata Banik (Code Review) gerrit at coreboot.org
Mon Oct 8 07:36:51 CEST 2018


Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/28961


Change subject: soc/intel/common/acpi: Fix ACPI Namespace lookup failure, AE_ALREADY_EXISTS issue
......................................................................

soc/intel/common/acpi: Fix ACPI Namespace lookup failure, AE_ALREADY_EXISTS issue

This patch fixes below ACPI compilation issue:

Found 1 external control methods, reparsing with new information
Pass 1 parse of [DSDT]
ACPI Error: [EPCS] Namespace lookup failure, AE_ALREADY_EXISTS (20160318/dsfield-660)
ACPI Error: [EMNA] Namespace lookup failure, AE_ALREADY_EXISTS (20160318/dsfield-660)
ACPI Error: [ELNG] Namespace lookup failure, AE_ALREADY_EXISTS (20160318/dsfield-660)
Pass 2 parse of [DSDT]
ACPI Warning: NsLookup: Type mismatch on EPCS (Integer), searching for (RegionField) (20160318/nsaccess-664)
ACPI Warning: NsLookup: Type mismatch on EMNA (Integer), searching for (RegionField) (20160318/nsaccess-664)
ACPI Warning: NsLookup: Type mismatch on ELNG (Integer), searching for (RegionField) (20160318/nsaccess-664)
Parsing Deferred Opcodes (Methods/Buffers/Packages/Regions)

TEST=Able to build sgx.asl without any ASL error.

Change-Id: If4e7d4c66b6aab6c081fa272d8c2c9a1f0651ef7
Signed-off-by: Subrata Banik <subrata.banik at intel.com>
---
M src/soc/intel/common/acpi/sgx.asl
1 file changed, 7 insertions(+), 7 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/28961/1

diff --git a/src/soc/intel/common/acpi/sgx.asl b/src/soc/intel/common/acpi/sgx.asl
index 43de44f..e801110 100644
--- a/src/soc/intel/common/acpi/sgx.asl
+++ b/src/soc/intel/common/acpi/sgx.asl
@@ -13,9 +13,9 @@
  * GNU General Public License for more details.
  */
 
-External(\_SB.EPCS, IntObj) // Enclave Page Cache (EPC) Status
-External(\_SB.EMNA, IntObj) // EPC base address
-External(\_SB.ELNG, IntObj) // EPC length
+//External(\_SB.EPCS, IntObj) // Enclave Page Cache (EPC) Status
+//External(\_SB.EMNA, IntObj) // EPC base address
+//External(\_SB.ELNG, IntObj) // EPC length
 
 Scope(\_SB)
 {
@@ -54,15 +54,15 @@
 			CreateQwordField (RBUF, ^BAR0._MIN, EMIN)
 			CreateQwordField (RBUF, ^BAR0._MAX, EMAX)
 			CreateQwordField (RBUF, ^BAR0._LEN, ELEN)
-			Store (\_SB.EMNA, EMIN)
-			Store (\_SB.ELNG, ELEN)
-			Subtract (Add (\_SB.EMNA, \_SB.ELNG), 1, EMAX)
+			Store (EMNA, EMIN)
+			Store (ELNG, ELEN)
+			Subtract (Add (EMNA, ELNG), 1, EMAX)
 			Return (RBUF)
 		}
 
 		Method (_STA, 0x0, NotSerialized)
 		{
-			If (LNotEqual (\_SB.EPCS, 0))
+			If (LNotEqual (EPCS, 0))
 			{
 				Return (0xF)
 			}

-- 
To view, visit https://review.coreboot.org/28961
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If4e7d4c66b6aab6c081fa272d8c2c9a1f0651ef7
Gerrit-Change-Number: 28961
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik <subrata.banik at intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181008/6087bd6c/attachment.html>


More information about the coreboot-gerrit mailing list