[coreboot-gerrit] Change in coreboot[master]: drivers/intel/fsp2_0: Hook up IntelFSP repo

Philipp Deppenwiese (Code Review) gerrit at coreboot.org
Sat Oct 13 01:20:57 CEST 2018


Philipp Deppenwiese has submitted this change and it was merged. ( https://review.coreboot.org/28593 )

Change subject: drivers/intel/fsp2_0: Hook up IntelFSP repo
......................................................................

drivers/intel/fsp2_0: Hook up IntelFSP repo

With https://github.com/IntelFsp/FSP/pull/4 merged, this allows using
Intel's FSP repo (that we mirror) to build a complete BIOS ifd region
with a simple coreboot build, automatically drawing in headers and
binaries.

This commit covers Apollolake, Coffeelake, Skylake, and Kabylake.

Skylake is using Kabylake's FSP since its own is FSP 1.1 and Kabylake's
also supports Skylake.

Another candidate (given 3rdparty/fsp's content) is Denverton NS, but
it requires changes to coreboot's FSP bindings to become compatible.

Cannonlake, Whiskeylake require an FSP release.

Change-Id: I8d838ca6555348ce877f54e95907e9fdf6b9f2e7
Signed-off-by: Patrick Georgi <pgeorgi at google.com>
Reviewed-on: https://review.coreboot.org/28593
Reviewed-by: Pratikkumar V Prajapati <pratikkumar.v.prajapati at intel.com>
Reviewed-by: Naresh Solanki <naresh.solanki at intel.com>
Reviewed-by: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
---
M src/drivers/intel/fsp2_0/Kconfig
M src/drivers/intel/fsp2_0/Makefile.inc
M src/soc/intel/apollolake/Kconfig
M src/soc/intel/apollolake/Makefile.inc
M src/soc/intel/cannonlake/Kconfig
M src/soc/intel/cannonlake/Makefile.inc
M src/soc/intel/skylake/Kconfig
M src/soc/intel/skylake/Makefile.inc
D src/vendorcode/intel/fsp/fsp2_0/apollolake/FspUpd.h
D src/vendorcode/intel/fsp/fsp2_0/apollolake/FspmUpd.h
D src/vendorcode/intel/fsp/fsp2_0/apollolake/FspsUpd.h
D src/vendorcode/intel/fsp/fsp2_0/coffeelake/FirmwareVersionInfoHob.h
D src/vendorcode/intel/fsp/fsp2_0/coffeelake/FspUpd.h
D src/vendorcode/intel/fsp/fsp2_0/coffeelake/FspmUpd.h
D src/vendorcode/intel/fsp/fsp2_0/coffeelake/FspsUpd.h
D src/vendorcode/intel/fsp/fsp2_0/coffeelake/FsptUpd.h
D src/vendorcode/intel/fsp/fsp2_0/coffeelake/MemInfoHob.h
D src/vendorcode/intel/fsp/fsp2_0/skykabylake/ConfigBlock/CpuConfigFspData.h
D src/vendorcode/intel/fsp/fsp2_0/skykabylake/FspUpd.h
D src/vendorcode/intel/fsp/fsp2_0/skykabylake/FspmUpd.h
D src/vendorcode/intel/fsp/fsp2_0/skykabylake/FspsUpd.h
D src/vendorcode/intel/fsp/fsp2_0/skykabylake/MemInfoHob.h
22 files changed, 65 insertions(+), 14,250 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Philipp Deppenwiese: Looks good to me, approved
  Naresh Solanki: Looks good to me, approved
  Pratikkumar V Prajapati: Looks good to me, approved




-- 
To view, visit https://review.coreboot.org/28593
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8d838ca6555348ce877f54e95907e9fdf6b9f2e7
Gerrit-Change-Number: 28593
Gerrit-PatchSet: 12
Gerrit-Owner: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Krystian Hebel (1002088)
Gerrit-Reviewer: Matt DeVillier <matt.devillier at gmail.com>
Gerrit-Reviewer: Naresh Solanki <naresh.solanki at intel.com>
Gerrit-Reviewer: Nathaniel L Desimone <nathaniel.l.desimone at intel.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Piotr Król <piotr.krol at 3mdeb.com>
Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati at intel.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer at coreboot.org>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181012/2aa0e400/attachment.html>


More information about the coreboot-gerrit mailing list