[coreboot-gerrit] Change in coreboot[master]: No need to include acpi_tables.c to Makefiles

Peter Lemenkov (Code Review) gerrit at coreboot.org
Sun Oct 7 10:43:14 CEST 2018


Peter Lemenkov has uploaded this change for review. ( https://review.coreboot.org/28954


Change subject: No need to include acpi_tables.c to Makefiles
......................................................................

No need to include acpi_tables.c to Makefiles

It always included if ACP is supported since commit
822bc65b0e8cb9c17721b8b776ec7ecf6ac4129e.

Change-Id: If17a6f43e368ccf850031b349714fa1ec4d02c1d
Signed-off-by: Peter Lemenkov <lemenkov at gmail.com>
---
M src/mainboard/compulab/intense_pc/Makefile.inc
M src/mainboard/intel/harcuvar/Makefile.inc
M src/mainboard/lenovo/l520/Makefile.inc
M src/mainboard/lenovo/t430/Makefile.inc
M src/mainboard/scaleway/tagada/Makefile.inc
5 files changed, 0 insertions(+), 5 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/28954/1

diff --git a/src/mainboard/compulab/intense_pc/Makefile.inc b/src/mainboard/compulab/intense_pc/Makefile.inc
index ed24e18..3dae61e 100644
--- a/src/mainboard/compulab/intense_pc/Makefile.inc
+++ b/src/mainboard/compulab/intense_pc/Makefile.inc
@@ -1,2 +1 @@
 romstage-y += gpio.c
-ramstage-y += acpi_tables.c
diff --git a/src/mainboard/intel/harcuvar/Makefile.inc b/src/mainboard/intel/harcuvar/Makefile.inc
index d100688..271a577 100644
--- a/src/mainboard/intel/harcuvar/Makefile.inc
+++ b/src/mainboard/intel/harcuvar/Makefile.inc
@@ -22,7 +22,6 @@
 ramstage-y += ramstage.c
 ramstage-y += boardid.c
 ramstage-y += hsio.c
-ramstage-$(CONFIG_HAVE_ACPI_TABLES) += acpi_tables.c
 ramstage-$(CONFIG_HAVE_ACPI_TABLES) += fadt.c
 
 CPPFLAGS_common += -Isrc/mainboard/$(MAINBOARDDIR)/
diff --git a/src/mainboard/lenovo/l520/Makefile.inc b/src/mainboard/lenovo/l520/Makefile.inc
index 892c815..5331f25 100644
--- a/src/mainboard/lenovo/l520/Makefile.inc
+++ b/src/mainboard/lenovo/l520/Makefile.inc
@@ -15,5 +15,4 @@
 
 romstage-y += romstage.c
 romstage-y += gpio.c
-ramstage-y += acpi_tables.c
 smm-y += smihandler.c
diff --git a/src/mainboard/lenovo/t430/Makefile.inc b/src/mainboard/lenovo/t430/Makefile.inc
index 794b5cd..558ab0a 100644
--- a/src/mainboard/lenovo/t430/Makefile.inc
+++ b/src/mainboard/lenovo/t430/Makefile.inc
@@ -1,6 +1,5 @@
 romstage-y += romstage.c
 romstage-y += gpio.c
-ramstage-y += acpi_tables.c
 smm-y += smihandler.c
 
 ramstage-$(CONFIG_MAINBOARD_USE_LIBGFXINIT) += gma-mainboard.ads
diff --git a/src/mainboard/scaleway/tagada/Makefile.inc b/src/mainboard/scaleway/tagada/Makefile.inc
index 7d426df..c33e993 100644
--- a/src/mainboard/scaleway/tagada/Makefile.inc
+++ b/src/mainboard/scaleway/tagada/Makefile.inc
@@ -20,7 +20,6 @@
 
 ramstage-y += ramstage.c
 ramstage-y += hsio.c
-ramstage-$(CONFIG_HAVE_ACPI_TABLES) += acpi_tables.c
 ramstage-$(CONFIG_HAVE_ACPI_TABLES) += fadt.c
 
 bootblock-y += bmcinfo.c

-- 
To view, visit https://review.coreboot.org/28954
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If17a6f43e368ccf850031b349714fa1ec4d02c1d
Gerrit-Change-Number: 28954
Gerrit-PatchSet: 1
Gerrit-Owner: Peter Lemenkov <lemenkov at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181007/793b0147/attachment.html>


More information about the coreboot-gerrit mailing list