<p>Peter Lemenkov has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/28954">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">No need to include acpi_tables.c to Makefiles<br><br>It always included if ACP is supported since commit<br>822bc65b0e8cb9c17721b8b776ec7ecf6ac4129e.<br><br>Change-Id: If17a6f43e368ccf850031b349714fa1ec4d02c1d<br>Signed-off-by: Peter Lemenkov <lemenkov@gmail.com><br>---<br>M src/mainboard/compulab/intense_pc/Makefile.inc<br>M src/mainboard/intel/harcuvar/Makefile.inc<br>M src/mainboard/lenovo/l520/Makefile.inc<br>M src/mainboard/lenovo/t430/Makefile.inc<br>M src/mainboard/scaleway/tagada/Makefile.inc<br>5 files changed, 0 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/28954/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/compulab/intense_pc/Makefile.inc b/src/mainboard/compulab/intense_pc/Makefile.inc</span><br><span>index ed24e18..3dae61e 100644</span><br><span>--- a/src/mainboard/compulab/intense_pc/Makefile.inc</span><br><span>+++ b/src/mainboard/compulab/intense_pc/Makefile.inc</span><br><span>@@ -1,2 +1 @@</span><br><span> romstage-y += gpio.c</span><br><span style="color: hsl(0, 100%, 40%);">-ramstage-y += acpi_tables.c</span><br><span>diff --git a/src/mainboard/intel/harcuvar/Makefile.inc b/src/mainboard/intel/harcuvar/Makefile.inc</span><br><span>index d100688..271a577 100644</span><br><span>--- a/src/mainboard/intel/harcuvar/Makefile.inc</span><br><span>+++ b/src/mainboard/intel/harcuvar/Makefile.inc</span><br><span>@@ -22,7 +22,6 @@</span><br><span> ramstage-y += ramstage.c</span><br><span> ramstage-y += boardid.c</span><br><span> ramstage-y += hsio.c</span><br><span style="color: hsl(0, 100%, 40%);">-ramstage-$(CONFIG_HAVE_ACPI_TABLES) += acpi_tables.c</span><br><span> ramstage-$(CONFIG_HAVE_ACPI_TABLES) += fadt.c</span><br><span> </span><br><span> CPPFLAGS_common += -Isrc/mainboard/$(MAINBOARDDIR)/</span><br><span>diff --git a/src/mainboard/lenovo/l520/Makefile.inc b/src/mainboard/lenovo/l520/Makefile.inc</span><br><span>index 892c815..5331f25 100644</span><br><span>--- a/src/mainboard/lenovo/l520/Makefile.inc</span><br><span>+++ b/src/mainboard/lenovo/l520/Makefile.inc</span><br><span>@@ -15,5 +15,4 @@</span><br><span> </span><br><span> romstage-y += romstage.c</span><br><span> romstage-y += gpio.c</span><br><span style="color: hsl(0, 100%, 40%);">-ramstage-y += acpi_tables.c</span><br><span> smm-y += smihandler.c</span><br><span>diff --git a/src/mainboard/lenovo/t430/Makefile.inc b/src/mainboard/lenovo/t430/Makefile.inc</span><br><span>index 794b5cd..558ab0a 100644</span><br><span>--- a/src/mainboard/lenovo/t430/Makefile.inc</span><br><span>+++ b/src/mainboard/lenovo/t430/Makefile.inc</span><br><span>@@ -1,6 +1,5 @@</span><br><span> romstage-y += romstage.c</span><br><span> romstage-y += gpio.c</span><br><span style="color: hsl(0, 100%, 40%);">-ramstage-y += acpi_tables.c</span><br><span> smm-y += smihandler.c</span><br><span> </span><br><span> ramstage-$(CONFIG_MAINBOARD_USE_LIBGFXINIT) += gma-mainboard.ads</span><br><span>diff --git a/src/mainboard/scaleway/tagada/Makefile.inc b/src/mainboard/scaleway/tagada/Makefile.inc</span><br><span>index 7d426df..c33e993 100644</span><br><span>--- a/src/mainboard/scaleway/tagada/Makefile.inc</span><br><span>+++ b/src/mainboard/scaleway/tagada/Makefile.inc</span><br><span>@@ -20,7 +20,6 @@</span><br><span> </span><br><span> ramstage-y += ramstage.c</span><br><span> ramstage-y += hsio.c</span><br><span style="color: hsl(0, 100%, 40%);">-ramstage-$(CONFIG_HAVE_ACPI_TABLES) += acpi_tables.c</span><br><span> ramstage-$(CONFIG_HAVE_ACPI_TABLES) += fadt.c</span><br><span> </span><br><span> bootblock-y += bmcinfo.c</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28954">change 28954</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28954"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: If17a6f43e368ccf850031b349714fa1ec4d02c1d </div>
<div style="display:none"> Gerrit-Change-Number: 28954 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Peter Lemenkov <lemenkov@gmail.com> </div>