[coreboot-gerrit] Change in coreboot[master]: treewide: use /usr/bin/env where appropriate

Patrick Georgi (Code Review) gerrit at coreboot.org
Thu Oct 18 18:31:57 CEST 2018


Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/28953 )

Change subject: treewide: use /usr/bin/env where appropriate
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://review.coreboot.org/#/c/28953/1/util/cbfstool/Makefile
File util/cbfstool/Makefile:

https://review.coreboot.org/#/c/28953/1/util/cbfstool/Makefile@9
PS1, Line 9: INSTALL ?= /usr/bin/env install
that's troublesome as well as "install" does very different things on different unixoids. I had data loss from that (on Solaris, I think), so if we expect this to run on non-GNU, I'd propose getting rid of uses of "install"



-- 
To view, visit https://review.coreboot.org/28953
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7546bcb881c532adc984577ecb0ee2ec4f2efe00
Gerrit-Change-Number: 28953
Gerrit-PatchSet: 1
Gerrit-Owner: Yegor Timoshenko <yegortimoshenko at riseup.net>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Yegor Timoshenko <yegortimoshenko at riseup.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus at gmail.com>
Gerrit-Comment-Date: Thu, 18 Oct 2018 16:31:57 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181018/04b7e676/attachment.html>


More information about the coreboot-gerrit mailing list