[coreboot-gerrit] Change in coreboot[master]: sb/intel/common: Add common reset handler

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/28862 )

Change subject: sb/intel/common: Add common reset handler
......................................................................


Patch Set 2:

(1 comment)

Now I'm wondering: With nb/intel/fsp_rangeley fixed, would it build
w/o a do_soft_reset() implementation?

I've never seen any Intel chipset that would not do a hard reset if
it detects a prior soft reset. So having a do_soft_reset() for Intel
doesn't make much sense.

The situation is even more annyoing if you look at soc/intel/common/.
They just redefined the meaning of the different resets.

https://review.coreboot.org/#/c/28862/2/src/southbridge/intel/fsp_rangeley/reset.c
File src/southbridge/intel/fsp_rangeley/reset.c:

https://review.coreboot.org/#/c/28862/2/src/southbridge/intel/fsp_rangeley/reset.c@a23
PS2, Line 23: 
Guess who seems to be the only one calling soft_reset()? it's
nb/intel/fsp_rangeley... That call should be fixed, I guess.



-- 
To view, visit https://review.coreboot.org/28862
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e359b0c4d5a1060edd0940d24c2f78dfed8a590
Gerrit-Change-Number: 28862
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Alexandru Gagniuc <alexandrux.gagniuc at intel.com>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot at felixheld.de>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 03 Oct 2018 13:48:38 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181003/a6d0cbd5/attachment.html>