[coreboot-gerrit] Change in coreboot[master]: sb/intel/common: Add common reset handler

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/28862 )

Change subject: sb/intel/common: Add common reset handler
......................................................................


Patch Set 2:

Ok, to clear this up a little. In the current definition by reset.h:

  * cpu_reset() was a cpu reset (for Intel) but dropped
  * soft_reset() is a system reset (for Intel)
  * hard_reset() is a full reset (for Intel)
  * global_reset() is not well specified but I bet always the same for Intel (either let the ME do it or do a ME+system reset)

Deviating from this was ok as long as only platform code called the
reset functions (it knew what was implemented as what). But if you
call them from common code (e.g. vboot) they have to match.


-- 
To view, visit https://review.coreboot.org/28862
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e359b0c4d5a1060edd0940d24c2f78dfed8a590
Gerrit-Change-Number: 28862
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Alexandru Gagniuc <alexandrux.gagniuc at intel.com>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot at felixheld.de>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 03 Oct 2018 14:02:37 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181003/de11921a/attachment.html>