[coreboot-gerrit] Change in ...coreboot[master]: qcs405: Add blsp uart driver

Fri Nov 30 15:07:58 CET 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29964 )

Change subject: qcs405: Add blsp uart driver
......................................................................

Patch Set 2:

(25 comments)

https://review.coreboot.org/#/c/29964/2/src/soc/qualcomm/qcs405/include/soc/cdp.h 
File src/soc/qualcomm/qcs405/include/soc/cdp.h:

https://review.coreboot.org/#/c/29964/2/src/soc/qualcomm/qcs405/include/soc/cdp.h@36 
PS2, Line 36: unsigned smem_get_board_machtype(void);
Prefer 'unsigned int' to bare use of 'unsigned'

https://review.coreboot.org/#/c/29964/2/src/soc/qualcomm/qcs405/include/soc/cdp.h@89 
PS2, Line 89: 	SPI_CS_0 ,
space prohibited before that ',' (ctx:WxE)

https://review.coreboot.org/#/c/29964/2/src/soc/qualcomm/qcs405/include/soc/cdp.h@119 
PS2, Line 119: 	unsigned count;
Prefer 'unsigned int' to bare use of 'unsigned'

https://review.coreboot.org/#/c/29964/2/src/soc/qualcomm/qcs405/include/soc/cdp.h@124 
PS2, Line 124: 	unsigned base;
Prefer 'unsigned int' to bare use of 'unsigned'

https://review.coreboot.org/#/c/29964/2/src/soc/qualcomm/qcs405/include/soc/cdp.h@126 
PS2, Line 126: 	unsigned is_macsec;
Prefer 'unsigned int' to bare use of 'unsigned'

https://review.coreboot.org/#/c/29964/2/src/soc/qualcomm/qcs405/include/soc/cdp.h@127 
PS2, Line 127: 	unsigned mac_pwr0;
Prefer 'unsigned int' to bare use of 'unsigned'

https://review.coreboot.org/#/c/29964/2/src/soc/qualcomm/qcs405/include/soc/cdp.h@128 
PS2, Line 128: 	unsigned mac_pwr1;
Prefer 'unsigned int' to bare use of 'unsigned'

https://review.coreboot.org/#/c/29964/2/src/soc/qualcomm/qcs405/include/soc/cdp.h@129 
PS2, Line 129: 	unsigned mac_conn_to_phy;
Prefer 'unsigned int' to bare use of 'unsigned'

https://review.coreboot.org/#/c/29964/2/src/soc/qualcomm/qcs405/include/soc/cdp.h@172 
PS2, Line 172: unsigned int get_board_index(unsigned machid);
Prefer 'unsigned int' to bare use of 'unsigned'

https://review.coreboot.org/#/c/29964/2/src/soc/qualcomm/qcs405/include/soc/cdp.h@173 
PS2, Line 173: void ipq_configure_gpio(const gpio_func_data_t *gpio, unsigned count);
Prefer 'unsigned int' to bare use of 'unsigned'

https://review.coreboot.org/#/c/29964/2/src/soc/qualcomm/qcs405/include/soc/iomap.h 
File src/soc/qualcomm/qcs405/include/soc/iomap.h:

https://review.coreboot.org/#/c/29964/2/src/soc/qualcomm/qcs405/include/soc/iomap.h@49 
PS2, Line 49: #define writel_i(v,a)        write32((void *)a, v)
space required after that ',' (ctx:VxV)

https://review.coreboot.org/#/c/29964/2/src/soc/qualcomm/qcs405/uart.c 
File src/soc/qualcomm/qcs405/uart.c:

https://review.coreboot.org/#/c/29964/2/src/soc/qualcomm/qcs405/uart.c@50 
PS2, Line 50: 	unsigned blsp_uart;
Prefer 'unsigned int' to bare use of 'unsigned'

https://review.coreboot.org/#/c/29964/2/src/soc/qualcomm/qcs405/uart.c@54 
PS2, Line 54: void ipq_configure_gpio(const gpio_func_data_t *gpio, unsigned count)
Prefer 'unsigned int' to bare use of 'unsigned'

https://review.coreboot.org/#/c/29964/2/src/soc/qualcomm/qcs405/uart.c@56 
PS2, Line 56:         int i;
code indent should use tabs where possible

https://review.coreboot.org/#/c/29964/2/src/soc/qualcomm/qcs405/uart.c@56 
PS2, Line 56:         int i;
please, no spaces at the start of a line

https://review.coreboot.org/#/c/29964/2/src/soc/qualcomm/qcs405/uart.c@58 
PS2, Line 58:         for (i = 0; i < count; i++) {
code indent should use tabs where possible

https://review.coreboot.org/#/c/29964/2/src/soc/qualcomm/qcs405/uart.c@58 
PS2, Line 58:         for (i = 0; i < count; i++) {
please, no spaces at the start of a line

https://review.coreboot.org/#/c/29964/2/src/soc/qualcomm/qcs405/uart.c@59 
PS2, Line 59:                 gpio_configure(gpio->gpio, gpio->func,
code indent should use tabs where possible

https://review.coreboot.org/#/c/29964/2/src/soc/qualcomm/qcs405/uart.c@59 
PS2, Line 59:                 gpio_configure(gpio->gpio, gpio->func,
please, no spaces at the start of a line

https://review.coreboot.org/#/c/29964/2/src/soc/qualcomm/qcs405/uart.c@60 
PS2, Line 60:                                 gpio->pull, gpio->drvstr, gpio->enable);
code indent should use tabs where possible

https://review.coreboot.org/#/c/29964/2/src/soc/qualcomm/qcs405/uart.c@60 
PS2, Line 60:                                 gpio->pull, gpio->drvstr, gpio->enable);
please, no spaces at the start of a line

https://review.coreboot.org/#/c/29964/2/src/soc/qualcomm/qcs405/uart.c@61 
PS2, Line 61:                 gpio++;
code indent should use tabs where possible

https://review.coreboot.org/#/c/29964/2/src/soc/qualcomm/qcs405/uart.c@61 
PS2, Line 61:                 gpio++;
please, no spaces at the start of a line

https://review.coreboot.org/#/c/29964/2/src/soc/qualcomm/qcs405/uart.c@62 
PS2, Line 62:         }
code indent should use tabs where possible

https://review.coreboot.org/#/c/29964/2/src/soc/qualcomm/qcs405/uart.c@62 
PS2, Line 62:         }
please, no spaces at the start of a line

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29964
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id9626c68eadead8b8ec5ffbc08cab7b0ec36478f
Gerrit-Change-Number: 29964
Gerrit-PatchSet: 2
Gerrit-Owner: nsekar at codeaurora.org
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Reviewer: nsekar at codeaurora.org
Gerrit-Comment-Date: Fri, 30 Nov 2018 14:07:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181130/1193122c/attachment.html>