<p><a href="https://review.coreboot.org/c/coreboot/+/29964">View Change</a></p><p>25 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29964/2/src/soc/qualcomm/qcs405/include/soc/cdp.h">File src/soc/qualcomm/qcs405/include/soc/cdp.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29964/2/src/soc/qualcomm/qcs405/include/soc/cdp.h@36">Patch Set #2, Line 36:</a> <code style="font-family:monospace,monospace">unsigned smem_get_board_machtype(void);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Prefer 'unsigned int' to bare use of 'unsigned'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29964/2/src/soc/qualcomm/qcs405/include/soc/cdp.h@89">Patch Set #2, Line 89:</a> <code style="font-family:monospace,monospace"> SPI_CS_0 ,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited before that ',' (ctx:WxE)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29964/2/src/soc/qualcomm/qcs405/include/soc/cdp.h@119">Patch Set #2, Line 119:</a> <code style="font-family:monospace,monospace"> unsigned count;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Prefer 'unsigned int' to bare use of 'unsigned'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29964/2/src/soc/qualcomm/qcs405/include/soc/cdp.h@124">Patch Set #2, Line 124:</a> <code style="font-family:monospace,monospace"> unsigned base;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Prefer 'unsigned int' to bare use of 'unsigned'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29964/2/src/soc/qualcomm/qcs405/include/soc/cdp.h@126">Patch Set #2, Line 126:</a> <code style="font-family:monospace,monospace"> unsigned is_macsec;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Prefer 'unsigned int' to bare use of 'unsigned'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29964/2/src/soc/qualcomm/qcs405/include/soc/cdp.h@127">Patch Set #2, Line 127:</a> <code style="font-family:monospace,monospace"> unsigned mac_pwr0;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Prefer 'unsigned int' to bare use of 'unsigned'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29964/2/src/soc/qualcomm/qcs405/include/soc/cdp.h@128">Patch Set #2, Line 128:</a> <code style="font-family:monospace,monospace"> unsigned mac_pwr1;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Prefer 'unsigned int' to bare use of 'unsigned'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29964/2/src/soc/qualcomm/qcs405/include/soc/cdp.h@129">Patch Set #2, Line 129:</a> <code style="font-family:monospace,monospace"> unsigned mac_conn_to_phy;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Prefer 'unsigned int' to bare use of 'unsigned'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29964/2/src/soc/qualcomm/qcs405/include/soc/cdp.h@172">Patch Set #2, Line 172:</a> <code style="font-family:monospace,monospace">unsigned int get_board_index(unsigned machid);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Prefer 'unsigned int' to bare use of 'unsigned'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29964/2/src/soc/qualcomm/qcs405/include/soc/cdp.h@173">Patch Set #2, Line 173:</a> <code style="font-family:monospace,monospace">void ipq_configure_gpio(const gpio_func_data_t *gpio, unsigned count);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Prefer 'unsigned int' to bare use of 'unsigned'</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29964/2/src/soc/qualcomm/qcs405/include/soc/iomap.h">File src/soc/qualcomm/qcs405/include/soc/iomap.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29964/2/src/soc/qualcomm/qcs405/include/soc/iomap.h@49">Patch Set #2, Line 49:</a> <code style="font-family:monospace,monospace">#define writel_i(v,a) write32((void *)a, v)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required after that ',' (ctx:VxV)</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29964/2/src/soc/qualcomm/qcs405/uart.c">File src/soc/qualcomm/qcs405/uart.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29964/2/src/soc/qualcomm/qcs405/uart.c@50">Patch Set #2, Line 50:</a> <code style="font-family:monospace,monospace"> unsigned blsp_uart;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Prefer 'unsigned int' to bare use of 'unsigned'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29964/2/src/soc/qualcomm/qcs405/uart.c@54">Patch Set #2, Line 54:</a> <code style="font-family:monospace,monospace">void ipq_configure_gpio(const gpio_func_data_t *gpio, unsigned count)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Prefer 'unsigned int' to bare use of 'unsigned'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29964/2/src/soc/qualcomm/qcs405/uart.c@56">Patch Set #2, Line 56:</a> <code style="font-family:monospace,monospace"> int i;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29964/2/src/soc/qualcomm/qcs405/uart.c@56">Patch Set #2, Line 56:</a> <code style="font-family:monospace,monospace"> int i;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29964/2/src/soc/qualcomm/qcs405/uart.c@58">Patch Set #2, Line 58:</a> <code style="font-family:monospace,monospace"> for (i = 0; i < count; i++) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29964/2/src/soc/qualcomm/qcs405/uart.c@58">Patch Set #2, Line 58:</a> <code style="font-family:monospace,monospace"> for (i = 0; i < count; i++) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29964/2/src/soc/qualcomm/qcs405/uart.c@59">Patch Set #2, Line 59:</a> <code style="font-family:monospace,monospace"> gpio_configure(gpio->gpio, gpio->func,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29964/2/src/soc/qualcomm/qcs405/uart.c@59">Patch Set #2, Line 59:</a> <code style="font-family:monospace,monospace"> gpio_configure(gpio->gpio, gpio->func,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29964/2/src/soc/qualcomm/qcs405/uart.c@60">Patch Set #2, Line 60:</a> <code style="font-family:monospace,monospace"> gpio->pull, gpio->drvstr, gpio->enable);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29964/2/src/soc/qualcomm/qcs405/uart.c@60">Patch Set #2, Line 60:</a> <code style="font-family:monospace,monospace"> gpio->pull, gpio->drvstr, gpio->enable);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29964/2/src/soc/qualcomm/qcs405/uart.c@61">Patch Set #2, Line 61:</a> <code style="font-family:monospace,monospace"> gpio++;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29964/2/src/soc/qualcomm/qcs405/uart.c@61">Patch Set #2, Line 61:</a> <code style="font-family:monospace,monospace"> gpio++;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29964/2/src/soc/qualcomm/qcs405/uart.c@62">Patch Set #2, Line 62:</a> <code style="font-family:monospace,monospace"> }</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29964/2/src/soc/qualcomm/qcs405/uart.c@62">Patch Set #2, Line 62:</a> <code style="font-family:monospace,monospace"> }</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/29964">change 29964</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/29964"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Id9626c68eadead8b8ec5ffbc08cab7b0ec36478f </div>
<div style="display:none"> Gerrit-Change-Number: 29964 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: nsekar@codeaurora.org </div>
<div style="display:none"> Gerrit-Reviewer: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Reviewer: nsekar@codeaurora.org </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 30 Nov 2018 14:07:58 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>