[coreboot-gerrit] Change in ...coreboot[master]: qcs405: Add blsp uart driver
build bot (Jenkins) (Code Review)
gerrit at coreboot.org
Fri Nov 30 11:16:26 CET 2018
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29964 )
Change subject: qcs405: Add blsp uart driver
......................................................................
Patch Set 1:
(25 comments)
https://review.coreboot.org/#/c/29964/1/src/soc/qualcomm/qcs405/include/soc/cdp.h
File src/soc/qualcomm/qcs405/include/soc/cdp.h:
https://review.coreboot.org/#/c/29964/1/src/soc/qualcomm/qcs405/include/soc/cdp.h@36
PS1, Line 36: unsigned smem_get_board_machtype(void);
Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/#/c/29964/1/src/soc/qualcomm/qcs405/include/soc/cdp.h@89
PS1, Line 89: SPI_CS_0 ,
space prohibited before that ',' (ctx:WxE)
https://review.coreboot.org/#/c/29964/1/src/soc/qualcomm/qcs405/include/soc/cdp.h@119
PS1, Line 119: unsigned count;
Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/#/c/29964/1/src/soc/qualcomm/qcs405/include/soc/cdp.h@124
PS1, Line 124: unsigned base;
Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/#/c/29964/1/src/soc/qualcomm/qcs405/include/soc/cdp.h@126
PS1, Line 126: unsigned is_macsec;
Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/#/c/29964/1/src/soc/qualcomm/qcs405/include/soc/cdp.h@127
PS1, Line 127: unsigned mac_pwr0;
Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/#/c/29964/1/src/soc/qualcomm/qcs405/include/soc/cdp.h@128
PS1, Line 128: unsigned mac_pwr1;
Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/#/c/29964/1/src/soc/qualcomm/qcs405/include/soc/cdp.h@129
PS1, Line 129: unsigned mac_conn_to_phy;
Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/#/c/29964/1/src/soc/qualcomm/qcs405/include/soc/cdp.h@172
PS1, Line 172: unsigned int get_board_index(unsigned machid);
Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/#/c/29964/1/src/soc/qualcomm/qcs405/include/soc/cdp.h@173
PS1, Line 173: void ipq_configure_gpio(const gpio_func_data_t *gpio, unsigned count);
Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/#/c/29964/1/src/soc/qualcomm/qcs405/include/soc/iomap.h
File src/soc/qualcomm/qcs405/include/soc/iomap.h:
https://review.coreboot.org/#/c/29964/1/src/soc/qualcomm/qcs405/include/soc/iomap.h@49
PS1, Line 49: #define writel_i(v,a) write32((void *)a, v)
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/29964/1/src/soc/qualcomm/qcs405/uart.c
File src/soc/qualcomm/qcs405/uart.c:
https://review.coreboot.org/#/c/29964/1/src/soc/qualcomm/qcs405/uart.c@50
PS1, Line 50: unsigned blsp_uart;
Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/#/c/29964/1/src/soc/qualcomm/qcs405/uart.c@54
PS1, Line 54: void ipq_configure_gpio(const gpio_func_data_t *gpio, unsigned count)
Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/#/c/29964/1/src/soc/qualcomm/qcs405/uart.c@56
PS1, Line 56: int i;
code indent should use tabs where possible
https://review.coreboot.org/#/c/29964/1/src/soc/qualcomm/qcs405/uart.c@56
PS1, Line 56: int i;
please, no spaces at the start of a line
https://review.coreboot.org/#/c/29964/1/src/soc/qualcomm/qcs405/uart.c@58
PS1, Line 58: for (i = 0; i < count; i++) {
code indent should use tabs where possible
https://review.coreboot.org/#/c/29964/1/src/soc/qualcomm/qcs405/uart.c@58
PS1, Line 58: for (i = 0; i < count; i++) {
please, no spaces at the start of a line
https://review.coreboot.org/#/c/29964/1/src/soc/qualcomm/qcs405/uart.c@59
PS1, Line 59: gpio_configure(gpio->gpio, gpio->func,
code indent should use tabs where possible
https://review.coreboot.org/#/c/29964/1/src/soc/qualcomm/qcs405/uart.c@59
PS1, Line 59: gpio_configure(gpio->gpio, gpio->func,
please, no spaces at the start of a line
https://review.coreboot.org/#/c/29964/1/src/soc/qualcomm/qcs405/uart.c@60
PS1, Line 60: gpio->pull, gpio->drvstr, gpio->enable);
code indent should use tabs where possible
https://review.coreboot.org/#/c/29964/1/src/soc/qualcomm/qcs405/uart.c@60
PS1, Line 60: gpio->pull, gpio->drvstr, gpio->enable);
please, no spaces at the start of a line
https://review.coreboot.org/#/c/29964/1/src/soc/qualcomm/qcs405/uart.c@61
PS1, Line 61: gpio++;
code indent should use tabs where possible
https://review.coreboot.org/#/c/29964/1/src/soc/qualcomm/qcs405/uart.c@61
PS1, Line 61: gpio++;
please, no spaces at the start of a line
https://review.coreboot.org/#/c/29964/1/src/soc/qualcomm/qcs405/uart.c@62
PS1, Line 62: }
code indent should use tabs where possible
https://review.coreboot.org/#/c/29964/1/src/soc/qualcomm/qcs405/uart.c@62
PS1, Line 62: }
please, no spaces at the start of a line
--
To view, visit https://review.coreboot.org/c/coreboot/+/29964
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id9626c68eadead8b8ec5ffbc08cab7b0ec36478f
Gerrit-Change-Number: 29964
Gerrit-PatchSet: 1
Gerrit-Owner: nsekar at codeaurora.org
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: nsekar at codeaurora.org
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 30 Nov 2018 10:16:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181130/86a0565e/attachment.html>
More information about the coreboot-gerrit
mailing list