[coreboot-gerrit] Change in ...coreboot[master]: drivers/intel/fsp2_0: Add hook to fix up FSP-S

[Nico Huber (Code Review)]

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/29899


Change subject: drivers/intel/fsp2_0: Add hook to fix up FSP-S
......................................................................

drivers/intel/fsp2_0: Add hook to fix up FSP-S

There may be bugs in one revision or another. Add a hook that is
directly called after FSP-S to allow the platform to fix things up.

Change-Id: I6e5a52752d757159f12a65dfa5d08ac5fd65c259
Signed-off-by: Nico Huber <nico.huber at secunet.com>
---
M src/drivers/intel/fsp2_0/include/fsp/api.h
M src/drivers/intel/fsp2_0/silicon_init.c
2 files changed, 9 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/29899/1

diff --git a/src/drivers/intel/fsp2_0/include/fsp/api.h b/src/drivers/intel/fsp2_0/include/fsp/api.h
index 5ed3801..dc3031e 100644
--- a/src/drivers/intel/fsp2_0/include/fsp/api.h
+++ b/src/drivers/intel/fsp2_0/include/fsp/api.h
@@ -72,6 +72,12 @@
 	struct mma_config_param *mma_cfg);
 
 /*
+ * Hook to fix settings made by FSP-S. Called directly after
+ * returning from the blob.
+ */
+void soc_fsp_silicon_init_fixups(void);
+
+/*
  * # DOCUMENTATION:
  *
  * This file defines the interface between coreboot and the FSP 2.0 wrapper
diff --git a/src/drivers/intel/fsp2_0/silicon_init.c b/src/drivers/intel/fsp2_0/silicon_init.c
index 0670663..7f56533 100644
--- a/src/drivers/intel/fsp2_0/silicon_init.c
+++ b/src/drivers/intel/fsp2_0/silicon_init.c
@@ -24,6 +24,8 @@
 
 struct fsp_header fsps_hdr;
 
+__weak void soc_fsp_silicon_init_fixups(void) {}
+
 static void do_silicon_init(struct fsp_header *hdr)
 {
 	FSPS_UPD *upd, *supd;
@@ -50,6 +52,7 @@
 	timestamp_add_now(TS_FSP_SILICON_INIT_START);
 	post_code(POST_FSP_SILICON_INIT);
 	status = silicon_init(upd);
+	soc_fsp_silicon_init_fixups();
 	timestamp_add_now(TS_FSP_SILICON_INIT_END);
 	post_code(POST_FSP_SILICON_EXIT);
 

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29899
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6e5a52752d757159f12a65dfa5d08ac5fd65c259
Gerrit-Change-Number: 29899
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181128/2aea2e01/attachment.html>