<p>Nico Huber has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/c/coreboot/+/29899">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">drivers/intel/fsp2_0: Add hook to fix up FSP-S<br><br>There may be bugs in one revision or another. Add a hook that is<br>directly called after FSP-S to allow the platform to fix things up.<br><br>Change-Id: I6e5a52752d757159f12a65dfa5d08ac5fd65c259<br>Signed-off-by: Nico Huber <nico.huber@secunet.com><br>---<br>M src/drivers/intel/fsp2_0/include/fsp/api.h<br>M src/drivers/intel/fsp2_0/silicon_init.c<br>2 files changed, 9 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/29899/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/drivers/intel/fsp2_0/include/fsp/api.h b/src/drivers/intel/fsp2_0/include/fsp/api.h</span><br><span>index 5ed3801..dc3031e 100644</span><br><span>--- a/src/drivers/intel/fsp2_0/include/fsp/api.h</span><br><span>+++ b/src/drivers/intel/fsp2_0/include/fsp/api.h</span><br><span>@@ -72,6 +72,12 @@</span><br><span>  struct mma_config_param *mma_cfg);</span><br><span> </span><br><span> /*</span><br><span style="color: hsl(120, 100%, 40%);">+ * Hook to fix settings made by FSP-S. Called directly after</span><br><span style="color: hsl(120, 100%, 40%);">+ * returning from the blob.</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+void soc_fsp_silicon_init_fixups(void);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/*</span><br><span>  * # DOCUMENTATION:</span><br><span>  *</span><br><span>  * This file defines the interface between coreboot and the FSP 2.0 wrapper</span><br><span>diff --git a/src/drivers/intel/fsp2_0/silicon_init.c b/src/drivers/intel/fsp2_0/silicon_init.c</span><br><span>index 0670663..7f56533 100644</span><br><span>--- a/src/drivers/intel/fsp2_0/silicon_init.c</span><br><span>+++ b/src/drivers/intel/fsp2_0/silicon_init.c</span><br><span>@@ -24,6 +24,8 @@</span><br><span> </span><br><span> struct fsp_header fsps_hdr;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+__weak void soc_fsp_silicon_init_fixups(void) {}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> static void do_silicon_init(struct fsp_header *hdr)</span><br><span> {</span><br><span>  FSPS_UPD *upd, *supd;</span><br><span>@@ -50,6 +52,7 @@</span><br><span>    timestamp_add_now(TS_FSP_SILICON_INIT_START);</span><br><span>        post_code(POST_FSP_SILICON_INIT);</span><br><span>    status = silicon_init(upd);</span><br><span style="color: hsl(120, 100%, 40%);">+   soc_fsp_silicon_init_fixups();</span><br><span>       timestamp_add_now(TS_FSP_SILICON_INIT_END);</span><br><span>  post_code(POST_FSP_SILICON_EXIT);</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/29899">change 29899</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/29899"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I6e5a52752d757159f12a65dfa5d08ac5fd65c259 </div>
<div style="display:none"> Gerrit-Change-Number: 29899 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Nico Huber <nico.h@gmx.de> </div>
<div style="display:none"> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>