[coreboot-gerrit] Change in coreboot[master]: mainboard/google/octopus/variants/ampton: I2C touchpad and touch-pane...

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/29644 )

Change subject: mainboard/google/octopus/variants/ampton: I2C touchpad and touch-panel tuning
......................................................................


Patch Set 3:

(3 comments)

https://review.coreboot.org/#/c/29644/3//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/29644/3//COMMIT_MSG@17
PS3, Line 17: Change-Id: I1acd26f95b7e947b7088cb25c1cdb686895cced0
You will need a "Signed-off-by" line


https://review.coreboot.org/#/c/29644/3/src/mainboard/google/octopus/variants/ampton/overridetree.cb
File src/mainboard/google/octopus/variants/ampton/overridetree.cb:

https://review.coreboot.org/#/c/29644/3/src/mainboard/google/octopus/variants/ampton/overridetree.cb@8
PS3, Line 8: .i2c[0] = {
           : 			.speed = I2C_SPEED_FAST,
           : 			.rise_time_ns = 152,
           : 			.fall_time_ns = 30,
           : 		},
Does i2c0 frequency look fine?


https://review.coreboot.org/#/c/29644/3/src/mainboard/google/octopus/variants/ampton/overridetree.cb@13
PS3, Line 13: .i2c[5] = {
            : 			.speed = I2C_SPEED_FAST,
            : 			.rise_time_ns = 104,
            : 			.fall_time_ns = 52,
            : 		},
Does this look fine?



-- 
To view, visit https://review.coreboot.org/29644
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1acd26f95b7e947b7088cb25c1cdb686895cced0
Gerrit-Change-Number: 29644
Gerrit-PatchSet: 3
Gerrit-Owner: Carl Yang <carl_yang at asus.corp-partner.google.com>
Gerrit-Reviewer: Carl Yang <carl_yang at asus.corp-partner.google.com>
Gerrit-Reviewer: Marco Chen <marcochen at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Furquan Shaikh <furquan at google.com>
Gerrit-CC: Randy Wang <randy2_wang at asus.corp-partner.google.com>
Gerrit-CC: YuCheng Hung <yucheng_hung at asus.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 15 Nov 2018 07:20:23 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181115/e7ccac2c/attachment.html>