<p><a href="https://review.coreboot.org/29644">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29644/3//COMMIT_MSG">Commit Message:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29644/3//COMMIT_MSG@17">Patch Set #3, Line 17:</a> <code style="font-family:monospace,monospace">Change-Id: I1acd26f95b7e947b7088cb25c1cdb686895cced0</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">You will need a "Signed-off-by" line</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29644/3/src/mainboard/google/octopus/variants/ampton/overridetree.cb">File src/mainboard/google/octopus/variants/ampton/overridetree.cb:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29644/3/src/mainboard/google/octopus/variants/ampton/overridetree.cb@8">Patch Set #3, Line 8:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">.i2c[0] = {<br>                      .speed = I2C_SPEED_FAST,<br>                      .rise_time_ns = 152,<br>                  .fall_time_ns = 30,<br>           },<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Does i2c0 frequency look fine?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29644/3/src/mainboard/google/octopus/variants/ampton/overridetree.cb@13">Patch Set #3, Line 13:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">.i2c[5] = {<br>                 .speed = I2C_SPEED_FAST,<br>                      .rise_time_ns = 104,<br>                  .fall_time_ns = 52,<br>           },<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Does this look fine?</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/29644">change 29644</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29644"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I1acd26f95b7e947b7088cb25c1cdb686895cced0 </div>
<div style="display:none"> Gerrit-Change-Number: 29644 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Carl Yang <carl_yang@asus.corp-partner.google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Carl Yang <carl_yang@asus.corp-partner.google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Marco Chen <marcochen@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-CC: Furquan Shaikh <furquan@google.com> </div>
<div style="display:none"> Gerrit-CC: Randy Wang <randy2_wang@asus.corp-partner.google.com> </div>
<div style="display:none"> Gerrit-CC: YuCheng Hung <yucheng_hung@asus.corp-partner.google.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 15 Nov 2018 07:20:23 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>