[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variant/nocturne: config GPP_E1 for WLAN_WAKE_L

Nick Vaccaro (Code Review) gerrit at coreboot.org
Tue Nov 13 22:49:06 CET 2018


Nick Vaccaro has uploaded this change for review. ( https://review.coreboot.org/29630


Change subject: mb/google/poppy/variant/nocturne: config GPP_E1 for WLAN_WAKE_L
......................................................................

mb/google/poppy/variant/nocturne: config GPP_E1 for WLAN_WAKE_L

The GPP_E1 gpio was incorrectly being defined as a no-connect.
Configure GPP_E1 for the WLAN_WAKE_L signal.

BUG=b:119508897
TEST=none

Change-Id: I4efb4f6d601e172ae4807901e3bd4c9954319f80
Signed-off-by: Nick Vaccaro <nvaccaro at google.com>
---
M src/mainboard/google/poppy/variants/nocturne/gpio.c
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/29630/1

diff --git a/src/mainboard/google/poppy/variants/nocturne/gpio.c b/src/mainboard/google/poppy/variants/nocturne/gpio.c
index 70b748b..c62317a 100644
--- a/src/mainboard/google/poppy/variants/nocturne/gpio.c
+++ b/src/mainboard/google/poppy/variants/nocturne/gpio.c
@@ -212,8 +212,8 @@
 
 	/* E0  : SATAXPCI0 ==> H1_PCH_INT_ODL */
 	PAD_CFG_GPI_APIC_INVERT(GPP_E0, NONE, PLTRST),
-	/* E1  : SATAXPCIE1 ==> NC */
-	PAD_CFG_NC(GPP_E1),
+	/* E1  : SATAXPCIE1 ==> WLAN_WAKE_L */
+	PAD_CFG_GPI_ACPI_SCI(GPP_E1, NONE, DEEP, INVERT),
 	/* E2  : SATAXPCIE2 ==> BT_DISABLE_L */
 	PAD_CFG_GPO(GPP_E2, 1, DEEP),
 	/* E3  : CPU_GP0 ==> NC */

-- 
To view, visit https://review.coreboot.org/29630
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4efb4f6d601e172ae4807901e3bd4c9954319f80
Gerrit-Change-Number: 29630
Gerrit-PatchSet: 1
Gerrit-Owner: Nick Vaccaro <nvaccaro at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181113/05ac3e0d/attachment-0001.html>


More information about the coreboot-gerrit mailing list