[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variant/nocturne: config GPP_E1 for WLAN_WAKE_L

Furquan Shaikh (Code Review) gerrit at coreboot.org
Wed Nov 14 00:00:27 CET 2018


Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/29630 )

Change subject: mb/google/poppy/variant/nocturne: config GPP_E1 for WLAN_WAKE_L
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/29630/1//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/29630/1//COMMIT_MSG@13
PS1, Line 13: none
Can you please check:
1. Suspend/resume to both S0ix and S3 still works fine (no unexpected wakes or suspend failures).
2. Wake from WLAN from both S0ix and S3 still works fine.



-- 
To view, visit https://review.coreboot.org/29630
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4efb4f6d601e172ae4807901e3bd4c9954319f80
Gerrit-Change-Number: 29630
Gerrit-PatchSet: 1
Gerrit-Owner: Nick Vaccaro <nvaccaro at google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 13 Nov 2018 23:00:27 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181113/735d8cc8/attachment.html>


More information about the coreboot-gerrit mailing list