<p>Nick Vaccaro has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/29630">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/poppy/variant/nocturne: config GPP_E1 for WLAN_WAKE_L<br><br>The GPP_E1 gpio was incorrectly being defined as a no-connect.<br>Configure GPP_E1 for the WLAN_WAKE_L signal.<br><br>BUG=b:119508897<br>TEST=none<br><br>Change-Id: I4efb4f6d601e172ae4807901e3bd4c9954319f80<br>Signed-off-by: Nick Vaccaro <nvaccaro@google.com><br>---<br>M src/mainboard/google/poppy/variants/nocturne/gpio.c<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/29630/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/poppy/variants/nocturne/gpio.c b/src/mainboard/google/poppy/variants/nocturne/gpio.c</span><br><span>index 70b748b..c62317a 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/nocturne/gpio.c</span><br><span>+++ b/src/mainboard/google/poppy/variants/nocturne/gpio.c</span><br><span>@@ -212,8 +212,8 @@</span><br><span> </span><br><span>  /* E0  : SATAXPCI0 ==> H1_PCH_INT_ODL */</span><br><span>  PAD_CFG_GPI_APIC_INVERT(GPP_E0, NONE, PLTRST),</span><br><span style="color: hsl(0, 100%, 40%);">-  /* E1  : SATAXPCIE1 ==> NC */</span><br><span style="color: hsl(0, 100%, 40%);">-        PAD_CFG_NC(GPP_E1),</span><br><span style="color: hsl(120, 100%, 40%);">+   /* E1  : SATAXPCIE1 ==> WLAN_WAKE_L */</span><br><span style="color: hsl(120, 100%, 40%);">+     PAD_CFG_GPI_ACPI_SCI(GPP_E1, NONE, DEEP, INVERT),</span><br><span>    /* E2  : SATAXPCIE2 ==> BT_DISABLE_L */</span><br><span>   PAD_CFG_GPO(GPP_E2, 1, DEEP),</span><br><span>        /* E3  : CPU_GP0 ==> NC */</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/29630">change 29630</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29630"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I4efb4f6d601e172ae4807901e3bd4c9954319f80 </div>
<div style="display:none"> Gerrit-Change-Number: 29630 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Nick Vaccaro <nvaccaro@google.com> </div>