[coreboot-gerrit] Change in coreboot[master]: siemens/mc_apl3: Remove the correction of the Tx signal for SATA

[Mario Scheithauer (Code Review)]

Mario Scheithauer has uploaded this change for review. ( https://review.coreboot.org/29527


Change subject: siemens/mc_apl3: Remove the correction of the Tx signal for SATA
......................................................................

siemens/mc_apl3: Remove the correction of the Tx signal for SATA

For this mainboard the correction of transmit voltage swing from SATA
interface is not necessary.

Change-Id: I900d0d44b88585c223182d85c78cf3ff1e3e9159
Signed-off-by: Mario Scheithauer <mario.scheithauer at siemens.com>
---
M src/mainboard/siemens/mc_apl1/variants/mc_apl3/mainboard.c
1 file changed, 0 insertions(+), 8 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/29527/1

diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl3/mainboard.c b/src/mainboard/siemens/mc_apl1/variants/mc_apl3/mainboard.c
index ade923a..bfcf38e 100644
--- a/src/mainboard/siemens/mc_apl1/variants/mc_apl3/mainboard.c
+++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl3/mainboard.c
@@ -52,14 +52,6 @@
 	 * offset 0x341C bit [3:0].
 	 */
 	pcr_or32(PID_LPC, PCR_LPC_PRC, (PCR_LPC_CCE_EN | PCR_LPC_PCE_EN));
-
-	/*
-	 * Correct the SATA transmit signal via the High Speed I/O Transmit
-	 * Control Register 3.
-	 * Bit [23:16] set the output voltage swing for TX line.
-	 * The value 0x4a sets the swing level to 0.58 V.
-	 */
-	pcr_rmw32(PID_MODPHY, TX_DWORD3, (0x00 << 16), (0x4a << 16));
 }
 
 static void wait_for_legacy_dev(void *unused)

-- 
To view, visit https://review.coreboot.org/29527
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I900d0d44b88585c223182d85c78cf3ff1e3e9159
Gerrit-Change-Number: 29527
Gerrit-PatchSet: 1
Gerrit-Owner: Mario Scheithauer <mario.scheithauer at siemens.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181107/e5120bb7/attachment.html>