<p>Mario Scheithauer has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/29527">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">siemens/mc_apl3: Remove the correction of the Tx signal for SATA<br><br>For this mainboard the correction of transmit voltage swing from SATA<br>interface is not necessary.<br><br>Change-Id: I900d0d44b88585c223182d85c78cf3ff1e3e9159<br>Signed-off-by: Mario Scheithauer <mario.scheithauer@siemens.com><br>---<br>M src/mainboard/siemens/mc_apl1/variants/mc_apl3/mainboard.c<br>1 file changed, 0 insertions(+), 8 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/29527/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl3/mainboard.c b/src/mainboard/siemens/mc_apl1/variants/mc_apl3/mainboard.c</span><br><span>index ade923a..bfcf38e 100644</span><br><span>--- a/src/mainboard/siemens/mc_apl1/variants/mc_apl3/mainboard.c</span><br><span>+++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl3/mainboard.c</span><br><span>@@ -52,14 +52,6 @@</span><br><span>        * offset 0x341C bit [3:0].</span><br><span>   */</span><br><span>  pcr_or32(PID_LPC, PCR_LPC_PRC, (PCR_LPC_CCE_EN | PCR_LPC_PCE_EN));</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-      /*</span><br><span style="color: hsl(0, 100%, 40%);">-       * Correct the SATA transmit signal via the High Speed I/O Transmit</span><br><span style="color: hsl(0, 100%, 40%);">-      * Control Register 3.</span><br><span style="color: hsl(0, 100%, 40%);">-   * Bit [23:16] set the output voltage swing for TX line.</span><br><span style="color: hsl(0, 100%, 40%);">-         * The value 0x4a sets the swing level to 0.58 V.</span><br><span style="color: hsl(0, 100%, 40%);">-        */</span><br><span style="color: hsl(0, 100%, 40%);">-     pcr_rmw32(PID_MODPHY, TX_DWORD3, (0x00 << 16), (0x4a << 16));</span><br><span> }</span><br><span> </span><br><span> static void wait_for_legacy_dev(void *unused)</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/29527">change 29527</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29527"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I900d0d44b88585c223182d85c78cf3ff1e3e9159 </div>
<div style="display:none"> Gerrit-Change-Number: 29527 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Mario Scheithauer <mario.scheithauer@siemens.com> </div>