[coreboot-gerrit] Change in coreboot[master]: nb/amd/amdmct/mct_ddr3: Replace MTRR addresses with macros

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/29525 )

Change subject: nb/amd/amdmct/mct_ddr3: Replace MTRR addresses with macros
......................................................................

nb/amd/amdmct/mct_ddr3: Replace MTRR addresses with macros

Change-Id: I6d161e9e44ebd284e229ea38b6e23d571aa7bf1e
Signed-off-by: Elyes HAOUAS <ehaouas at noos.fr>
Reviewed-on: https://review.coreboot.org/29525
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Patrick Georgi <pgeorgi at google.com>
---
M src/northbridge/amd/amdmct/mct_ddr3/mct_d.c
1 file changed, 5 insertions(+), 4 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Patrick Georgi: Looks good to me, approved



diff --git a/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c b/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c
index cd1f165..34d1c1f 100644
--- a/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c
+++ b/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c
@@ -39,6 +39,7 @@
 #include <southbridge/amd/common/reset.h>
 #include <cpu/x86/msr.h>
 #include <cpu/amd/msr.h>
+#include <cpu/x86/mtrr.h>
 #include <arch/acpi.h>
 #include <string.h>
 #include <device/dram/ddr3.h>
@@ -3577,10 +3578,10 @@
 	mctHookBeforeAnyTraining(pMCTstat, pDCTstatA);
 	if (!is_fam15h()) {
 		/* TODO: should be in mctHookBeforeAnyTraining */
-		_WRMSR(0x26C, 0x04040404, 0x04040404);
-		_WRMSR(0x26D, 0x04040404, 0x04040404);
-		_WRMSR(0x26E, 0x04040404, 0x04040404);
-		_WRMSR(0x26F, 0x04040404, 0x04040404);
+		_WRMSR(MTRR_FIX_4K_E0000, 0x04040404, 0x04040404);
+		_WRMSR(MTRR_FIX_4K_E8000, 0x04040404, 0x04040404);
+		_WRMSR(MTRR_FIX_4K_F0000, 0x04040404, 0x04040404);
+		_WRMSR(MTRR_FIX_4K_F8000, 0x04040404, 0x04040404);
 	}
 
 	if (nv_DQSTrainCTL) {

-- 
To view, visit https://review.coreboot.org/29525
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6d161e9e44ebd284e229ea38b6e23d571aa7bf1e
Gerrit-Change-Number: 29525
Gerrit-PatchSet: 3
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181108/1bb2bc18/attachment.html>