[coreboot-gerrit] Change in coreboot[master]: kahlee: Set the SMI mask when initializing the ec

[Raul Rangel (Code Review)]

Raul Rangel has uploaded this change for review. ( https://review.coreboot.org/26702


Change subject: kahlee: Set the SMI mask when initializing the ec
......................................................................

kahlee: Set the SMI mask when initializing the ec

Before this fix, the SMI mask would always be 0 when in depthcharge.

This is what rambi does: https://github.com/coreboot/coreboot/blob/master/src/mainboard/google/rambi/ec.c

I'm not sure why other boards don't need to do this.

DO NOT MERGE

There is an issue with entering S5 from an SMI handler. Merging this
will cause a reboot instead of a shutdown in depthcharge.

BUG=b:80295434
TEST=Built and observed the SMI mask while depthcharge is loading
SMI mask:            0x0000000000000001
SCI mask:            0x0000000000000000

Change-Id: Iad0ee76e289b6bbeb6d272df5ce6cfb2079c5647
Signed-off-by: Raul E Rangel <rrangel at chromium.org>
---
M src/mainboard/google/kahlee/ec.c
1 file changed, 4 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/26702/1

diff --git a/src/mainboard/google/kahlee/ec.c b/src/mainboard/google/kahlee/ec.c
index d2933a6..4cdb391 100644
--- a/src/mainboard/google/kahlee/ec.c
+++ b/src/mainboard/google/kahlee/ec.c
@@ -22,6 +22,7 @@
 
 static void ramstage_ec_init(void)
 {
+	bool s3_wakeup = acpi_is_wakeup_s3();
 	const struct google_chromeec_event_info info = {
 		.log_events = MAINBOARD_EC_LOG_EVENTS,
 		.sci_events = MAINBOARD_EC_SCI_EVENTS,
@@ -32,6 +33,9 @@
 	printk(BIOS_DEBUG, "mainboard: EC init\n");
 
 	google_chromeec_events_init(&info, acpi_is_wakeup_s3());
+
+	if (!s3_wakeup)
+		google_chromeec_set_smi_mask(MAINBOARD_EC_SMI_EVENTS);
 }
 
 static void early_ec_init(void)

-- 
To view, visit https://review.coreboot.org/26702
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iad0ee76e289b6bbeb6d272df5ce6cfb2079c5647
Gerrit-Change-Number: 26702
Gerrit-PatchSet: 1
Gerrit-Owner: Raul Rangel <rrangel at chromium.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180530/38f3a143/attachment.html>