[coreboot-gerrit] Change in coreboot[master]: stoneyridge: Call APM_CNT_FINALIZE

Raul Rangel (Code Review) gerrit at coreboot.org
Wed May 30 18:33:33 CEST 2018


Raul Rangel has uploaded this change for review. ( https://review.coreboot.org/26701


Change subject: stoneyridge: Call APM_CNT_FINALIZE
......................................................................

stoneyridge: Call APM_CNT_FINALIZE

I'm not sure if this is actually required or not. The stoneyridge
smihandler doesn't actually handle this command.

BUG=b:80295434
TEST=Boot on grunt

Change-Id: I7ab85ac58a8f39f8519cdb3bff748d64d495bb7d
Signed-off-by: Raul E Rangel <rrangel at chromium.org>
---
M src/soc/amd/stoneyridge/finalize.c
1 file changed, 4 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/26701/1

diff --git a/src/soc/amd/stoneyridge/finalize.c b/src/soc/amd/stoneyridge/finalize.c
index 21d203c..e51dd61 100644
--- a/src/soc/amd/stoneyridge/finalize.c
+++ b/src/soc/amd/stoneyridge/finalize.c
@@ -13,6 +13,7 @@
  * GNU General Public License for more details.
  */
 
+#include <arch/io.h>
 #include <cpu/x86/mp.h>
 #include <cpu/x86/msr.h>
 #include <cpu/amd/amdfam15.h>
@@ -53,6 +54,9 @@
 {
 	finalize_cores();
 
+	printk(BIOS_DEBUG, "Finalizing SMM.\n");
+	outb(APM_CNT_FINALIZE, APM_CNT);
+
 	post_code(POST_OS_BOOT);
 }
 

-- 
To view, visit https://review.coreboot.org/26701
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7ab85ac58a8f39f8519cdb3bff748d64d495bb7d
Gerrit-Change-Number: 26701
Gerrit-PatchSet: 1
Gerrit-Owner: Raul Rangel <rrangel at chromium.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180530/d6f1f864/attachment.html>


More information about the coreboot-gerrit mailing list