<p>Raul Rangel has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/26701">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">stoneyridge: Call APM_CNT_FINALIZE<br><br>I'm not sure if this is actually required or not. The stoneyridge<br>smihandler doesn't actually handle this command.<br><br>BUG=b:80295434<br>TEST=Boot on grunt<br><br>Change-Id: I7ab85ac58a8f39f8519cdb3bff748d64d495bb7d<br>Signed-off-by: Raul E Rangel <rrangel@chromium.org><br>---<br>M src/soc/amd/stoneyridge/finalize.c<br>1 file changed, 4 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/26701/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/amd/stoneyridge/finalize.c b/src/soc/amd/stoneyridge/finalize.c</span><br><span>index 21d203c..e51dd61 100644</span><br><span>--- a/src/soc/amd/stoneyridge/finalize.c</span><br><span>+++ b/src/soc/amd/stoneyridge/finalize.c</span><br><span>@@ -13,6 +13,7 @@</span><br><span>  * GNU General Public License for more details.</span><br><span>  */</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+#include <arch/io.h></span><br><span> #include <cpu/x86/mp.h></span><br><span> #include <cpu/x86/msr.h></span><br><span> #include <cpu/amd/amdfam15.h></span><br><span>@@ -53,6 +54,9 @@</span><br><span> {</span><br><span>     finalize_cores();</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ printk(BIOS_DEBUG, "Finalizing SMM.\n");</span><br><span style="color: hsl(120, 100%, 40%);">+    outb(APM_CNT_FINALIZE, APM_CNT);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>   post_code(POST_OS_BOOT);</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/26701">change 26701</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/26701"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I7ab85ac58a8f39f8519cdb3bff748d64d495bb7d </div>
<div style="display:none"> Gerrit-Change-Number: 26701 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Raul Rangel <rrangel@chromium.org> </div>