<p>Raul Rangel has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/26702">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">kahlee: Set the SMI mask when initializing the ec<br><br>Before this fix, the SMI mask would always be 0 when in depthcharge.<br><br>This is what rambi does: https://github.com/coreboot/coreboot/blob/master/src/mainboard/google/rambi/ec.c<br><br>I'm not sure why other boards don't need to do this.<br><br>DO NOT MERGE<br><br>There is an issue with entering S5 from an SMI handler. Merging this<br>will cause a reboot instead of a shutdown in depthcharge.<br><br>BUG=b:80295434<br>TEST=Built and observed the SMI mask while depthcharge is loading<br>SMI mask:            0x0000000000000001<br>SCI mask:            0x0000000000000000<br><br>Change-Id: Iad0ee76e289b6bbeb6d272df5ce6cfb2079c5647<br>Signed-off-by: Raul E Rangel <rrangel@chromium.org><br>---<br>M src/mainboard/google/kahlee/ec.c<br>1 file changed, 4 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/26702/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/kahlee/ec.c b/src/mainboard/google/kahlee/ec.c</span><br><span>index d2933a6..4cdb391 100644</span><br><span>--- a/src/mainboard/google/kahlee/ec.c</span><br><span>+++ b/src/mainboard/google/kahlee/ec.c</span><br><span>@@ -22,6 +22,7 @@</span><br><span> </span><br><span> static void ramstage_ec_init(void)</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+     bool s3_wakeup = acpi_is_wakeup_s3();</span><br><span>        const struct google_chromeec_event_info info = {</span><br><span>             .log_events = MAINBOARD_EC_LOG_EVENTS,</span><br><span>               .sci_events = MAINBOARD_EC_SCI_EVENTS,</span><br><span>@@ -32,6 +33,9 @@</span><br><span>   printk(BIOS_DEBUG, "mainboard: EC init\n");</span><br><span> </span><br><span>    google_chromeec_events_init(&info, acpi_is_wakeup_s3());</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+        if (!s3_wakeup)</span><br><span style="color: hsl(120, 100%, 40%);">+               google_chromeec_set_smi_mask(MAINBOARD_EC_SMI_EVENTS);</span><br><span> }</span><br><span> </span><br><span> static void early_ec_init(void)</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/26702">change 26702</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/26702"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Iad0ee76e289b6bbeb6d272df5ce6cfb2079c5647 </div>
<div style="display:none"> Gerrit-Change-Number: 26702 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Raul Rangel <rrangel@chromium.org> </div>