[coreboot-gerrit] Change in coreboot[master]: src/drivers: Get rid of whitespace before tab

Mon May 28 15:49:31 CEST 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26649 )

Change subject: src/drivers: Get rid of whitespace before tab
......................................................................

Patch Set 1:

(24 comments)

https://review.coreboot.org/#/c/26649/1/src/drivers/aspeed/common/ast_tables.h
File src/drivers/aspeed/common/ast_tables.h:

https://review.coreboot.org/#/c/26649/1/src/drivers/aspeed/common/ast_tables.h@85
PS1, Line 85: 	{0x76, 0x63, 0x01},				        /* 03: VCLK36	*/
line over 80 characters

https://review.coreboot.org/#/c/26649/1/src/drivers/aspeed/common/ast_tables.h@86
PS1, Line 86: 	{0xEE, 0x67, 0x01},				        /* 04: VCLK40	*/
line over 80 characters

https://review.coreboot.org/#/c/26649/1/src/drivers/aspeed/common/ast_tables.h@88
PS1, Line 88: 	{0xC6, 0x64, 0x01},          	        /* 06: VCLK50	*/
please, no space before tabs

https://review.coreboot.org/#/c/26649/1/src/drivers/aspeed/common/ast_tables.h@89
PS1, Line 89: 	{0x94, 0x62, 0x01},          	        /* 07: VCLK56_25	*/
please, no space before tabs

https://review.coreboot.org/#/c/26649/1/src/drivers/aspeed/common/ast_tables.h@90
PS1, Line 90: 	{0x80, 0x64, 0x00},          	        /* 08: VCLK65		*/
please, no space before tabs

https://review.coreboot.org/#/c/26649/1/src/drivers/aspeed/common/ast_tables.h@91
PS1, Line 91: 	{0x7B, 0x63, 0x00},          	        /* 09: VCLK75	        */
please, no space before tabs

https://review.coreboot.org/#/c/26649/1/src/drivers/aspeed/common/ast_tables.h@92
PS1, Line 92: 	{0x67, 0x62, 0x00},				        /* 0A: VCLK78_75	*/
line over 80 characters

https://review.coreboot.org/#/c/26649/1/src/drivers/aspeed/common/ast_tables.h@93
PS1, Line 93: 	{0x7C, 0x62, 0x00},          	        /* 0B: VCLK94_5	*/
please, no space before tabs

https://review.coreboot.org/#/c/26649/1/src/drivers/aspeed/common/ast_tables.h@94
PS1, Line 94: 	{0x8E, 0x62, 0x00},          	        /* 0C: VCLK108	*/
please, no space before tabs

https://review.coreboot.org/#/c/26649/1/src/drivers/aspeed/common/ast_tables.h@95
PS1, Line 95: 	{0x85, 0x24, 0x00},          	        /* 0D: VCLK135	*/
please, no space before tabs

https://review.coreboot.org/#/c/26649/1/src/drivers/aspeed/common/ast_tables.h@96
PS1, Line 96: 	{0x67, 0x22, 0x00},          	        /* 0E: VCLK157_5	*/
please, no space before tabs

https://review.coreboot.org/#/c/26649/1/src/drivers/aspeed/common/ast_tables.h@97
PS1, Line 97: 	{0x6A, 0x22, 0x00},				        /* 0F: VCLK162	*/
line over 80 characters

https://review.coreboot.org/#/c/26649/1/src/drivers/aspeed/common/ast_tables.h@98
PS1, Line 98: 	{0x4d, 0x4c, 0x80},				        /* 10: VCLK154	*/
line over 80 characters

https://review.coreboot.org/#/c/26649/1/src/drivers/ati/ragexl/xlinit.c
File src/drivers/ati/ragexl/xlinit.c:

https://review.coreboot.org/#/c/26649/1/src/drivers/ati/ragexl/xlinit.c@562
PS1, Line 562: 	for (j = 0; j < ARRAY_SIZE(aty_chips); j++)
suspect code indent for conditional statements (8, 8)

https://review.coreboot.org/#/c/26649/1/src/drivers/ati/ragexl/xlinit.c@572
PS1, Line 572: 	printk(BIOS_SPEW, "ati_ragexl_init: Unknown mach64 0x%04x rev 0x%04x\n", type, rev);
line over 80 characters

https://review.coreboot.org/#/c/26649/1/src/drivers/ati/ragexl/xlinit.c@572
PS1, Line 572: 	printk(BIOS_SPEW, "ati_ragexl_init: Unknown mach64 0x%04x rev 0x%04x\n", type, rev);
Prefer using '"%s...", __func__' to using 'ati_ragexl_init', this function's name, in a string

https://review.coreboot.org/#/c/26649/1/src/drivers/ati/ragexl/xlinit.c@573
PS1, Line 573: 	return ;
space prohibited before semicolon

https://review.coreboot.org/#/c/26649/1/src/drivers/ati/ragexl/xlinit.c@576
PS1, Line 576: 	printk(BIOS_INFO, "ati_ragexl_init: %s [0x%04x rev 0x%02x]\n", chipname, type, rev);
line over 80 characters

https://review.coreboot.org/#/c/26649/1/src/drivers/ati/ragexl/xlinit.c@576
PS1, Line 576: 	printk(BIOS_INFO, "ati_ragexl_init: %s [0x%04x rev 0x%02x]\n", chipname, type, rev);
Prefer using '"%s...", __func__' to using 'ati_ragexl_init', this function's name, in a string

https://review.coreboot.org/#/c/26649/1/src/drivers/ati/ragexl/xlinit.c@578
PS1, Line 578: 	if (M64_HAS(INTEGRATED)) {
suspect code indent for conditional statements (8, 8)

https://review.coreboot.org/#/c/26649/1/src/drivers/ati/ragexl/xlinit.c@606
PS1, Line 606: 	if (M64_HAS(GTB_DSP) && (pll_ref_div = aty_ld_pll(PLL_REF_DIV, info))) {
suspect code indent for conditional statements (8, 8)

https://review.coreboot.org/#/c/26649/1/src/drivers/ati/ragexl/xlinit.c@606
PS1, Line 606: 	if (M64_HAS(GTB_DSP) && (pll_ref_div = aty_ld_pll(PLL_REF_DIV, info))) {
do not use assignment in if condition

https://review.coreboot.org/#/c/26649/1/src/drivers/xgi/common/initdef.h
File src/drivers/xgi/common/initdef.h:

https://review.coreboot.org/#/c/26649/1/src/drivers/xgi/common/initdef.h@116
PS1, Line 116: #define SetPALTV                0x0100		/* Deprecated here, now in TVMode */
line over 80 characters

https://review.coreboot.org/#/c/26649/1/src/drivers/xgi/common/initdef.h@131
PS1, Line 131: #define SetCRT2ToTVNoHiVision	(SetCRT2ToYPbPr525750 | SetCRT2ToSCART | SetCRT2ToSVIDEO | SetCRT2ToAVIDEO)
line over 80 characters

-- 
To view, visit https://review.coreboot.org/26649
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9ca055679c0332613afb2bb2ed86df165de3baf
Gerrit-Change-Number: 26649
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 28 May 2018 13:49:31 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180528/1529da77/attachment.html>