<p><a href="https://review.coreboot.org/26649">View Change</a></p><p>24 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/26649/1/src/drivers/aspeed/common/ast_tables.h">File src/drivers/aspeed/common/ast_tables.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26649/1/src/drivers/aspeed/common/ast_tables.h@85">Patch Set #1, Line 85:</a> <code style="font-family:monospace,monospace"> {0x76, 0x63, 0x01}, /* 03: VCLK36 */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26649/1/src/drivers/aspeed/common/ast_tables.h@86">Patch Set #1, Line 86:</a> <code style="font-family:monospace,monospace"> {0xEE, 0x67, 0x01}, /* 04: VCLK40 */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26649/1/src/drivers/aspeed/common/ast_tables.h@88">Patch Set #1, Line 88:</a> <code style="font-family:monospace,monospace"> {0xC6, 0x64, 0x01}, /* 06: VCLK50 */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no space before tabs</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26649/1/src/drivers/aspeed/common/ast_tables.h@89">Patch Set #1, Line 89:</a> <code style="font-family:monospace,monospace"> {0x94, 0x62, 0x01}, /* 07: VCLK56_25 */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no space before tabs</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26649/1/src/drivers/aspeed/common/ast_tables.h@90">Patch Set #1, Line 90:</a> <code style="font-family:monospace,monospace"> {0x80, 0x64, 0x00}, /* 08: VCLK65 */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no space before tabs</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26649/1/src/drivers/aspeed/common/ast_tables.h@91">Patch Set #1, Line 91:</a> <code style="font-family:monospace,monospace"> {0x7B, 0x63, 0x00}, /* 09: VCLK75 */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no space before tabs</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26649/1/src/drivers/aspeed/common/ast_tables.h@92">Patch Set #1, Line 92:</a> <code style="font-family:monospace,monospace"> {0x67, 0x62, 0x00}, /* 0A: VCLK78_75 */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26649/1/src/drivers/aspeed/common/ast_tables.h@93">Patch Set #1, Line 93:</a> <code style="font-family:monospace,monospace"> {0x7C, 0x62, 0x00}, /* 0B: VCLK94_5 */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no space before tabs</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26649/1/src/drivers/aspeed/common/ast_tables.h@94">Patch Set #1, Line 94:</a> <code style="font-family:monospace,monospace"> {0x8E, 0x62, 0x00}, /* 0C: VCLK108 */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no space before tabs</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26649/1/src/drivers/aspeed/common/ast_tables.h@95">Patch Set #1, Line 95:</a> <code style="font-family:monospace,monospace"> {0x85, 0x24, 0x00}, /* 0D: VCLK135 */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no space before tabs</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26649/1/src/drivers/aspeed/common/ast_tables.h@96">Patch Set #1, Line 96:</a> <code style="font-family:monospace,monospace"> {0x67, 0x22, 0x00}, /* 0E: VCLK157_5 */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no space before tabs</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26649/1/src/drivers/aspeed/common/ast_tables.h@97">Patch Set #1, Line 97:</a> <code style="font-family:monospace,monospace"> {0x6A, 0x22, 0x00}, /* 0F: VCLK162 */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26649/1/src/drivers/aspeed/common/ast_tables.h@98">Patch Set #1, Line 98:</a> <code style="font-family:monospace,monospace"> {0x4d, 0x4c, 0x80}, /* 10: VCLK154 */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/26649/1/src/drivers/ati/ragexl/xlinit.c">File src/drivers/ati/ragexl/xlinit.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26649/1/src/drivers/ati/ragexl/xlinit.c@562">Patch Set #1, Line 562:</a> <code style="font-family:monospace,monospace"> for (j = 0; j < ARRAY_SIZE(aty_chips); j++)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">suspect code indent for conditional statements (8, 8)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26649/1/src/drivers/ati/ragexl/xlinit.c@572">Patch Set #1, Line 572:</a> <code style="font-family:monospace,monospace"> printk(BIOS_SPEW, "ati_ragexl_init: Unknown mach64 0x%04x rev 0x%04x\n", type, rev);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26649/1/src/drivers/ati/ragexl/xlinit.c@572">Patch Set #1, Line 572:</a> <code style="font-family:monospace,monospace"> printk(BIOS_SPEW, "ati_ragexl_init: Unknown mach64 0x%04x rev 0x%04x\n", type, rev);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Prefer using '"%s...", __func__' to using 'ati_ragexl_init', this function's name, in a string</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26649/1/src/drivers/ati/ragexl/xlinit.c@573">Patch Set #1, Line 573:</a> <code style="font-family:monospace,monospace"> return ;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited before semicolon</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26649/1/src/drivers/ati/ragexl/xlinit.c@576">Patch Set #1, Line 576:</a> <code style="font-family:monospace,monospace"> printk(BIOS_INFO, "ati_ragexl_init: %s [0x%04x rev 0x%02x]\n", chipname, type, rev);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26649/1/src/drivers/ati/ragexl/xlinit.c@576">Patch Set #1, Line 576:</a> <code style="font-family:monospace,monospace"> printk(BIOS_INFO, "ati_ragexl_init: %s [0x%04x rev 0x%02x]\n", chipname, type, rev);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Prefer using '"%s...", __func__' to using 'ati_ragexl_init', this function's name, in a string</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26649/1/src/drivers/ati/ragexl/xlinit.c@578">Patch Set #1, Line 578:</a> <code style="font-family:monospace,monospace"> if (M64_HAS(INTEGRATED)) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">suspect code indent for conditional statements (8, 8)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26649/1/src/drivers/ati/ragexl/xlinit.c@606">Patch Set #1, Line 606:</a> <code style="font-family:monospace,monospace"> if (M64_HAS(GTB_DSP) && (pll_ref_div = aty_ld_pll(PLL_REF_DIV, info))) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">suspect code indent for conditional statements (8, 8)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26649/1/src/drivers/ati/ragexl/xlinit.c@606">Patch Set #1, Line 606:</a> <code style="font-family:monospace,monospace"> if (M64_HAS(GTB_DSP) && (pll_ref_div = aty_ld_pll(PLL_REF_DIV, info))) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">do not use assignment in if condition</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/26649/1/src/drivers/xgi/common/initdef.h">File src/drivers/xgi/common/initdef.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26649/1/src/drivers/xgi/common/initdef.h@116">Patch Set #1, Line 116:</a> <code style="font-family:monospace,monospace">#define SetPALTV 0x0100 /* Deprecated here, now in TVMode */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26649/1/src/drivers/xgi/common/initdef.h@131">Patch Set #1, Line 131:</a> <code style="font-family:monospace,monospace">#define SetCRT2ToTVNoHiVision (SetCRT2ToYPbPr525750 | SetCRT2ToSCART | SetCRT2ToSVIDEO | SetCRT2ToAVIDEO)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/26649">change 26649</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/26649"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ia9ca055679c0332613afb2bb2ed86df165de3baf </div>
<div style="display:none"> Gerrit-Change-Number: 26649 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Elyes HAOUAS <ehaouas@noos.fr> </div>
<div style="display:none"> Gerrit-CC: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 28 May 2018 13:49:31 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>