[coreboot-gerrit] Change in coreboot[master]: atlas ish: ish configuration

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/26277 )

Change subject: atlas ish: ish configuration
......................................................................


Patch Set 2:

(5 comments)

https://review.coreboot.org/#/c/26277/2//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/26277/2//COMMIT_MSG@12
PS2, Line 12: Previous flag "IshEnable" is removed.
Why?


https://review.coreboot.org/#/c/26277/2/src/mainboard/google/poppy/variants/atlas/gpio.c
File src/mainboard/google/poppy/variants/atlas/gpio.c:

https://review.coreboot.org/#/c/26277/2/src/mainboard/google/poppy/variants/atlas/gpio.c@60
PS2, Line 60: PAD_CFG_NC
> wouldn't we still need to see the trackpad IRQ […]
Yes, we would.


https://review.coreboot.org/#/c/26277/2/src/mainboard/google/poppy/variants/atlas/gpio.c@54
PS2, Line 54: #if (IS_ENABLED(CONFIG_SOC_ISH_ENABLE))
            : 	/* A19 : ISH_GP1 ==> TRACKPAD_INT_L */
            : 	PAD_CFG_NF(GPP_A19, NONE, DEEP, NF1),
            : 	/* A20 : ISH_GP2 ==> ISH_UART0_RXD */
            : 	PAD_CFG_NF(GPP_A20, NONE, DEEP, NF1),
            : #else
            : 	PAD_CFG_NC(GPP_A19),
            : 	PAD_CFG_NC(GPP_A20),
            : #endif
This can be handled dynamically at runtime depending upon the ISH device tree config.


https://review.coreboot.org/#/c/26277/2/src/soc/intel/skylake/chip.h
File src/soc/intel/skylake/chip.h:

https://review.coreboot.org/#/c/26277/2/src/soc/intel/skylake/chip.h@292
PS2, Line 292: * IshEnable is deprecated; use SOC_ISH_ENABLE instead */
why?


https://review.coreboot.org/#/c/26277/2/src/soc/intel/skylake/chip.c
File src/soc/intel/skylake/chip.c:

https://review.coreboot.org/#/c/26277/2/src/soc/intel/skylake/chip.c@139
PS2, Line 139: IS_ENABLED(CONFIG_SOC_ISH_ENABLE);
Instead of adding another Kconfig option, can this be done based on the state of dev->enabled for ISH?



-- 
To view, visit https://review.coreboot.org/26277
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I606705bed4030469b71ef630cfdd974601a4f899
Gerrit-Change-Number: 26277
Gerrit-PatchSet: 2
Gerrit-Owner: Li1 Feng <li1.feng at intel.com>
Gerrit-Reviewer: Caveh Jalali <caveh at google.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Kyoung Il Kim <kyoung.il.kim at intel.com>
Gerrit-Reviewer: Rushikesh S Kadam <rushikesh.s.kadam at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Reviewer: caveh jalali <caveh at chromium.org>
Gerrit-CC: Furquan Shaikh <furquan at google.com>
Gerrit-Comment-Date: Tue, 15 May 2018 06:04:50 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180515/68084e38/attachment.html>