<p><a href="https://review.coreboot.org/26277">View Change</a></p><p>5 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/26277/2//COMMIT_MSG">Commit Message:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26277/2//COMMIT_MSG@12">Patch Set #2, Line 12:</a> <code style="font-family:monospace,monospace">Previous flag "IshEnable" is removed.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Why?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/26277/2/src/mainboard/google/poppy/variants/atlas/gpio.c">File src/mainboard/google/poppy/variants/atlas/gpio.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26277/2/src/mainboard/google/poppy/variants/atlas/gpio.c@60">Patch Set #2, Line 60:</a> <code style="font-family:monospace,monospace">PAD_CFG_NC</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">wouldn't we still need to see the trackpad IRQ […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Yes, we would.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26277/2/src/mainboard/google/poppy/variants/atlas/gpio.c@54">Patch Set #2, Line 54:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">#if (IS_ENABLED(CONFIG_SOC_ISH_ENABLE))<br>      /* A19 : ISH_GP1 ==> TRACKPAD_INT_L */<br>     PAD_CFG_NF(GPP_A19, NONE, DEEP, NF1),<br> /* A20 : ISH_GP2 ==> ISH_UART0_RXD */<br>      PAD_CFG_NF(GPP_A20, NONE, DEEP, NF1),<br>#else<br>  PAD_CFG_NC(GPP_A19),<br>  PAD_CFG_NC(GPP_A20),<br>#endif<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">This can be handled dynamically at runtime depending upon the ISH device tree config.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/26277/2/src/soc/intel/skylake/chip.h">File src/soc/intel/skylake/chip.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26277/2/src/soc/intel/skylake/chip.h@292">Patch Set #2, Line 292:</a> <code style="font-family:monospace,monospace">* IshEnable is deprecated; use SOC_ISH_ENABLE instead */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">why?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/26277/2/src/soc/intel/skylake/chip.c">File src/soc/intel/skylake/chip.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26277/2/src/soc/intel/skylake/chip.c@139">Patch Set #2, Line 139:</a> <code style="font-family:monospace,monospace">IS_ENABLED(CONFIG_SOC_ISH_ENABLE);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Instead of adding another Kconfig option, can this be done based on the state of dev->enabled for ISH?</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/26277">change 26277</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/26277"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I606705bed4030469b71ef630cfdd974601a4f899 </div>
<div style="display:none"> Gerrit-Change-Number: 26277 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Li1 Feng <li1.feng@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Caveh Jalali <caveh@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Duncan Laurie <dlaurie@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Hannah Williams <hannah.williams@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kyoung Il Kim <kyoung.il.kim@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Rushikesh S Kadam <rushikesh.s.kadam@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Reviewer: caveh jalali <caveh@chromium.org> </div>
<div style="display:none"> Gerrit-CC: Furquan Shaikh <furquan@google.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 15 May 2018 06:04:50 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>