[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variants/nocturne: Update Slave Addresses of Max98373...

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/27167 )

Change subject: mb/google/poppy/variants/nocturne: Update Slave Addresses of Max98373 Amp's
......................................................................

mb/google/poppy/variants/nocturne: Update Slave Addresses of Max98373 Amp's

When played Left Only Audio and Right Only Audio, we observed that Audio
got swapped. Left Data played on Right Speaker and Viceversa.

This patch fixes the above issue.

BUG=b:73635449
TEST=Play Left only & Right only Audio and cross check Audio.

Change-Id: Ie9c417ad0634a76fc8a4126ee75886603f1b3da0
Signed-off-by: Sathyanarayana Nujella <sathyanarayana.nujella at intel.com>
Reviewed-on: https://review.coreboot.org/27167
Reviewed-by: Furquan Shaikh <furquan at google.com>
Reviewed-by: Nick Vaccaro <nvaccaro at google.com>
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
---
M src/mainboard/google/poppy/variants/nocturne/devicetree.cb
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Furquan Shaikh: Looks good to me, approved
  Nick Vaccaro: Looks good to me, but someone else must approve



diff --git a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb
index 0b30caa..de9c91c 100644
--- a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb
+++ b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb
@@ -317,7 +317,7 @@
 				register "uid" = "0"
 				register "desc" = ""RIGHT SPEAKER AMP""
 				register "name" = ""MAXR""
-				device i2c 31 on end
+				device i2c 32 on end
 			end
 			chip drivers/i2c/max98373
 				register "vmon_slot_no" = "6"
@@ -325,7 +325,7 @@
 				register "uid" = "1"
 				register "desc" = ""LEFT SPEAKER AMP""
 				register "name" = ""MAXL""
-				device i2c 32 on end
+				device i2c 31 on end
 			end
 		end # I2C #4 - Audio
 		device pci 1c.0 on

-- 
To view, visit https://review.coreboot.org/27167
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie9c417ad0634a76fc8a4126ee75886603f1b3da0
Gerrit-Change-Number: 27167
Gerrit-PatchSet: 2
Gerrit-Owner: Sathyanarayana Nujella <sathyanarayana.nujella at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: HARSHAPRIYA N <harshapriya.n at intel.com>
Gerrit-Reviewer: Jairaj Arava <jairaj.arava at intel.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Sathya Prakash M R <sathya.prakash.m.r at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180621/7cb83b7e/attachment.html>