<p>Patrick Georgi <strong>merged</strong> this change.</p><p><a href="https://review.coreboot.org/27167">View Change</a></p><div style="white-space:pre-wrap">Approvals:
build bot (Jenkins): Verified
Furquan Shaikh: Looks good to me, approved
Nick Vaccaro: Looks good to me, but someone else must approve
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/poppy/variants/nocturne: Update Slave Addresses of Max98373 Amp's<br><br>When played Left Only Audio and Right Only Audio, we observed that Audio<br>got swapped. Left Data played on Right Speaker and Viceversa.<br><br>This patch fixes the above issue.<br><br>BUG=b:73635449<br>TEST=Play Left only & Right only Audio and cross check Audio.<br><br>Change-Id: Ie9c417ad0634a76fc8a4126ee75886603f1b3da0<br>Signed-off-by: Sathyanarayana Nujella <sathyanarayana.nujella@intel.com><br>Reviewed-on: https://review.coreboot.org/27167<br>Reviewed-by: Furquan Shaikh <furquan@google.com><br>Reviewed-by: Nick Vaccaro <nvaccaro@google.com><br>Tested-by: build bot (Jenkins) <no-reply@coreboot.org><br>---<br>M src/mainboard/google/poppy/variants/nocturne/devicetree.cb<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb</span><br><span>index 0b30caa..de9c91c 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb</span><br><span>+++ b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb</span><br><span>@@ -317,7 +317,7 @@</span><br><span> register "uid" = "0"</span><br><span> register "desc" = ""RIGHT SPEAKER AMP""</span><br><span> register "name" = ""MAXR""</span><br><span style="color: hsl(0, 100%, 40%);">- device i2c 31 on end</span><br><span style="color: hsl(120, 100%, 40%);">+ device i2c 32 on end</span><br><span> end</span><br><span> chip drivers/i2c/max98373</span><br><span> register "vmon_slot_no" = "6"</span><br><span>@@ -325,7 +325,7 @@</span><br><span> register "uid" = "1"</span><br><span> register "desc" = ""LEFT SPEAKER AMP""</span><br><span> register "name" = ""MAXL""</span><br><span style="color: hsl(0, 100%, 40%);">- device i2c 32 on end</span><br><span style="color: hsl(120, 100%, 40%);">+ device i2c 31 on end</span><br><span> end</span><br><span> end # I2C #4 - Audio</span><br><span> device pci 1c.0 on</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27167">change 27167</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27167"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Ie9c417ad0634a76fc8a4126ee75886603f1b3da0 </div>
<div style="display:none"> Gerrit-Change-Number: 27167 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Sathyanarayana Nujella <sathyanarayana.nujella@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: HARSHAPRIYA N <harshapriya.n@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jairaj Arava <jairaj.arava@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Nick Vaccaro <nvaccaro@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Sathya Prakash M R <sathya.prakash.m.r@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>