[coreboot-gerrit] Change in coreboot[master]: drivers/i2c/da7219: Allow disabling micbias-pulse feature

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/27613 )

Change subject: drivers/i2c/da7219: Allow disabling micbias-pulse feature
......................................................................

drivers/i2c/da7219: Allow disabling micbias-pulse feature

These two da7219_aad properties are optional:
- dlg,micbias-pulse-lvl : Mic bias higher voltage pulse level (mV).
        [<2800>, <2900>]
- dlg,micbias-pulse-time : Mic bias higher voltage pulse duration (ms)

When the Mic Bias Higher Voltage feature is not required, firmware should
just not provide the dlg,micbias-pulse-lvl and dlg,micbias-pulse-time
properties.

Signed-off-by: Daniel Kurtz <djkurtz at chromium.org>

BUG=b:111700809
TEST=On grunt:
 No "Invalid micbias pulse level" in dmesg

Change-Id: Ie99a8962e78c68b3f6927d0de34168f265d4efa9
Reviewed-on: https://review.coreboot.org/27613
Reviewed-by: Furquan Shaikh <furquan at google.com>
Reviewed-by: Akshu Agrawal <akshu.agrawal at amd.com>
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
---
M src/drivers/i2c/da7219/da7219.c
1 file changed, 6 insertions(+), 4 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Furquan Shaikh: Looks good to me, approved
  Akshu Agrawal: Looks good to me, but someone else must approve



diff --git a/src/drivers/i2c/da7219/da7219.c b/src/drivers/i2c/da7219/da7219.c
index b8af689..43e6076 100644
--- a/src/drivers/i2c/da7219/da7219.c
+++ b/src/drivers/i2c/da7219/da7219.c
@@ -77,10 +77,12 @@
 	acpi_dp_add_integer(aad, "dlg,c-mic-btn-thr", config->c_mic_btn_thr);
 	acpi_dp_add_integer(aad, "dlg,btn-avg", config->btn_avg);
 	acpi_dp_add_integer(aad, "dlg,adc-1bit-rpt", config->adc_1bit_rpt);
-	acpi_dp_add_integer(aad, "dlg,micbias-pulse-lvl",
-			    config->micbias_pulse_lvl);
-	acpi_dp_add_integer(aad, "dlg,micbias-pulse-time",
-			    config->micbias_pulse_time);
+	if (config->micbias_pulse_lvl > 0) {
+		acpi_dp_add_integer(aad, "dlg,micbias-pulse-lvl",
+				    config->micbias_pulse_lvl);
+		acpi_dp_add_integer(aad, "dlg,micbias-pulse-time",
+				    config->micbias_pulse_time);
+	}
 
 	/* DA7219 Properties */
 	dsd = acpi_dp_new_table("_DSD");

-- 
To view, visit https://review.coreboot.org/27613
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie99a8962e78c68b3f6927d0de34168f265d4efa9
Gerrit-Change-Number: 27613
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Kurtz <djkurtz at google.com>
Gerrit-Reviewer: Akshu Agrawal <akshu.agrawal at amd.com>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at chromium.org>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180730/d5aec9d1/attachment.html>